Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(arch): add operator groups #573

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

jpeeler
Copy link

@jpeeler jpeeler commented Nov 16, 2018

This adds a section on operator groups. It also removes the obsolete
section "namespace control loop", since namespaces aren't annotated any
more.

I tried to take into account #571, since it'll soon be done. It will still have to be further modified if work is done to make CSV visibility more granular, but not too much.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2018
@njhale njhale closed this Nov 26, 2018
@njhale njhale reopened this Nov 26, 2018
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - Looking really good! I just have a few nits.

@jpeeler jpeeler force-pushed the docs-operator-group branch from 360c6cd to 586fc9e Compare November 26, 2018 19:04
@njhale
Copy link
Member

njhale commented Nov 26, 2018

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2018
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2018
This adds a section on operator groups. It also removes the obsolete
section "namespace control loop", since namespaces aren't annotated any
more.
@jpeeler jpeeler force-pushed the docs-operator-group branch from 586fc9e to 3e9f69e Compare December 6, 2018 21:59
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2018
@jpeeler
Copy link
Author

jpeeler commented Dec 6, 2018

This has now been updated to account for changes in:
#589
#601

@openshift-ci-robot
Copy link
Collaborator

@jpeeler: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 3e9f69e link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2018
@ecordell ecordell merged commit 052cd2d into operator-framework:master Dec 10, 2018
ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
@njhale njhale added the docs label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants