Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e): fix CSV tests #599

Merged
merged 2 commits into from
Dec 5, 2018
Merged

fix(e2e): fix CSV tests #599

merged 2 commits into from
Dec 5, 2018

Conversation

njhale
Copy link
Member

@njhale njhale commented Dec 4, 2018

Description

  • Looks in testNamespace instead of operatorNamespace for created CSVs and Deployments in TestCreateCSVWithOwnedAPIService.
  • Creates CSV first before use in CRD OwnerReferences (UID was empty which meant that changes to the CRD would not requeue the CSV).

Supersedes #582

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 4, 2018
@njhale
Copy link
Member Author

njhale commented Dec 4, 2018

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2018
@njhale njhale mentioned this pull request Dec 4, 2018
Closed
@openshift-ci-robot
Copy link
Collaborator

@njhale: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-olm 120a530 link /test e2e-aws-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ecordell
ecordell reviewed Dec 5, 2018
View reviewed changes
test/e2e/csv_e2e_test.go

fmt.Println("checking for deployment")
// Poll for deployment to be ready
err = wait.Poll(pollInterval, pollDuration, func() (bool, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason we removed the deployment check?

(It's fine as long as there's another test somewhere that can verify that if the CSV succeeded, the deployment is actually running)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ocs e2e tests poll for deployment status, so nevermind

ecordell
ecordell approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

test/e2e/csv_e2e_test.go

fmt.Println("checking for deployment")
// Poll for deployment to be ready
err = wait.Poll(pollInterval, pollDuration, func() (bool, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ocs e2e tests poll for deployment status, so nevermind

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2018
@njhale njhale merged commit b62b5a2 into operator-framework:master Dec 5, 2018
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
@njhale
Merge pull request operator-framework#599 from njhale/fix-tests
8293b9f 
fix(e2e): fix CSV tests
@njhale njhale added the kind/bug Categorizes issue or PR as related to a bug. label Mar 19, 2019
@njhale njhale deleted the fix-tests branch September 30, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell approved these changes

@jpeeler jpeeler Awaiting requested review from jpeeler

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@njhale @openshift-ci-robot @ecordell @alecmerdler