Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSVPhaseSucceeded for Copied ClusterServiceVersions #613

Conversation

alecmerdler
Copy link
Member

Description

Was previously using phase: Installing.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: alecmerdler

If they are not already assigned, you can assign the PR to them by writing /assign @alecmerdler in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 10, 2018
@openshift-ci-robot
Copy link
Collaborator

@alecmerdler: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 0d50c3e link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ecordell
Copy link
Member

In #589 the control loop is updated to copy the CSV status every time it changes, so that target CSVs always have status that matches the primary. (e.g. if they go unhealthy)

@alecmerdler
Copy link
Member Author

@ecordell Ah okay, I was definitely seeing different status.phase for copied CSVs when using an OperatorGroup.

@ecordell
Copy link
Member

@alecmerdler I think this is fixed now that #589 is merged. I'll close for now and we can re-open if you find any issues in the UI

@ecordell ecordell closed this Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants