Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(fake): add fake for registry client #630

Merged
merged 1 commit into from
Dec 18, 2018
Merged

chore(fake): add fake for registry client #630

merged 1 commit into from
Dec 18, 2018

Conversation

ecordell
Copy link
Member

No description provided.

@ecordell ecordell requested a review from alecmerdler December 18, 2018 18:11
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 18, 2018
@ecordell
Copy link
Member Author

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2018
alecmerdler
alecmerdler approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2018
@ecordell ecordell merged commit 7977ada into operator-framework:master Dec 18, 2018
@ecordell ecordell deleted the fake-registry-client branch December 18, 2018 18:28
@openshift-ci-robot
Copy link
Collaborator

@ecordell: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-olm 979d39a link /test e2e-aws-olm
ci/prow/e2e-aws 979d39a link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
@ecordell
Merge pull request operator-framework#630 from ecordell/fake-registry…
2537620 
…-client

chore(fake): add fake for registry client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler alecmerdler approved these changes

@njhale njhale Awaiting requested review from njhale

Assignees

@alecmerdler alecmerdler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecordell @openshift-ci-robot @alecmerdler