Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requeue subscriptions on catalogsource change #633

Merged
merged 3 commits into from
Dec 18, 2018
Merged

Requeue subscriptions on catalogsource change #633

merged 3 commits into from
Dec 18, 2018

Conversation

ecordell
Copy link
Member

@ecordell ecordell commented Dec 18, 2018 •
edited
Loading

This PR attempts to clean up several issues:

  • Subscriptions shouldn't be set to AtLatestKnown if we haven't created a CSV
  • Requeue dependent subscriptions when catalogsources change
  • Add sourceNamespace to packages subscription

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 18, 2018
@jpeeler jpeeler mentioned this pull request Dec 18, 2018
Closed
@ecordell ecordell changed the title Requeue subs Requeue subscriptions on catalogsource change Dec 18, 2018
njhale
njhale approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2018
@njhale
Copy link
Member

njhale commented Dec 18, 2018

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2018
@ecordell
Copy link
Member Author

tests are passing in ci, it's just stuck cleaning up the cluster

@ecordell ecordell merged commit c53c51a into operator-framework:master Dec 18, 2018
@openshift-ci-robot
Copy link
Collaborator

@ecordell: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 8269ad6 link /test e2e-aws
ci/prow/e2e-aws-olm 8269ad6 link /test e2e-aws-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ecordell ecordell deleted the requeue-subs branch December 21, 2018 13:31
ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
@ecordell
Merge pull request operator-framework#633 from ecordell/requeue-subs
5a2ca28 
Requeue subscriptions on catalogsource change
@njhale njhale added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhale njhale njhale approved these changes

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

Assignees

@njhale njhale

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecordell @njhale @openshift-ci-robot