-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consume Operator Registry from PackageManifest Server #639
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alecmerdler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
stopCh := make(chan struct{}) | ||
|
||
add, modify, delete, err := prov.Subscribe(test.namespace, stopCh) | ||
// TODO(alecmerdler) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be easiest to pull in the server
from operator-registry and start it up for testing?
@alecmerdler: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@alecmerdler: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
superseded by #650 |
Description
Replace the in-memory,
ConfigMap
implementation with the gRPC interface provided by theoperator-registry
server.Addresses https://jira.coreos.com/browse/ALM-831