feat(csv): add installmodes to CSV spec #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
njhale
force-pushed
the
csv-installmodes
branch
2 times, most recently
from
981fe23 to
6f04eb2
Compare
openshift-ci-robot
added
size/L
njhale
force-pushed
the
csv-installmodes
branch
4 times, most recently
from
b66d1ef to
1927601
Compare
|
Do you need to run codegen on this? |
Yes, I do. I was planning on running it after I finish writing tests. |
njhale
force-pushed
the
csv-installmodes
branch
3 times, most recently
from
e13b55a to
7e7550f
Compare
njhale
force-pushed
the
csv-installmodes
branch
2 times, most recently
from
9641742 to
d0a7ac1
Compare
openshift-ci-robot
added
size/XL
njhale
force-pushed
the
csv-installmodes
branch
3 times, most recently
from
df5a7c5 to
686e561
Compare
openshift-ci-robot
removed
the
size/XL
openshift-ci-robot
added
the
size/XXL
njhale
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
ecordell
reviewed
Jan 3, 2019
| namespaceList := []string{} | ||
| if selector.Empty() || selector == nil { | ||
| namespaceList = append(namespaceList, corev1.NamespaceAll) | ||
| namespaceSet := make(map[string]struct{}) |
There was a problem hiding this comment.
This is getting hard to follow now - can we divide it by whether you're using targetNamespace list vs. a selector?
njhale
force-pushed
the
csv-installmodes
branch
from
88731c6 to
1f63aec
Compare
- Adds installmodes to templates - Regenerates manifests
njhale
force-pushed
the
csv-installmodes
branch
from
1f63aec to
b8cbe26
Compare
|
/retest |
|
/test e2e-aws |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
feat(csv): add installmodes to CSV spec
njhale
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses ALM-842 and ALM-843
/assign @alecmerdler @ecordell