Add minimum kube version to CSV & check it against server version #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
dinhxuanvu
force-pushed
the
min-kube
branch
2 times, most recently
from
cf3e9a8 to
1058462
Compare
|
@dinhxuanvu can you rebase this on master? that should re-kick the tests and also remove the gitlab required check |
dinhxuanvu
changed the title
dinhxuanvu
force-pushed
the
min-kube
branch
9 times, most recently
from
e2b3767 to
531267d
Compare
openshift-ci-robot
added
size/L
dinhxuanvu
force-pushed
the
min-kube
branch
7 times, most recently
from
61d29de to
c6c7b84
Compare
dinhxuanvu
force-pushed
the
min-kube
branch
3 times, most recently
from
1bad5c0 to
88f95d0
Compare
dinhxuanvu
force-pushed
the
min-kube
branch
7 times, most recently
from
ffe216a to
c2137af
Compare
|
/retest |
dinhxuanvu
force-pushed
the
min-kube
branch
2 times, most recently
from
a9c1cd8 to
3332712
Compare
|
/retest |
dinhxuanvu
force-pushed
the
min-kube
branch
3 times, most recently
from
d599c64 to
8eabf30
Compare
|
/retest |
Check new CSV field against server version reported from discovery and fail requirement check if version is earlier than necessary.
CSV must contain minimum kube version under spec.minKubeVersion. OLM will retrieve that info from CSV and check it against server version to determine its capability. If not compatible, OLM will not install operator(s). Signed-off-by: Vu Dinh <vdinh@redhat.com>
The format of kube version in CSV should be Major.Minor.Patch. For example, 1.1.1 is correct. Signed-off-by: Vu Dinh <vdinh@redhat.com>
|
/test e2e-aws |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
Add minimum kube version to CSV & check it against server version
njhale
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSV must contain minimum kube version under spec.minKubeVersion.
OLM will retrieve that info from CSV and check it against server
version to determine its capability. If not compatible, OLM will
not install operator(s).
Signed-off-by: Vu Dinh vdinh@redhat.com