test(catalog): add e2e test to verify configmap changes are detected #670

ecordell · 2019-01-15T16:33:05Z

and recorded on the catalogsource object

This was an attempt to replicate an issue marketplace was seeing, but the test appears to pass with no additional changes.

test/e2e/catalog_e2e_test.go

njhale

/lgtm

njhale · 2019-01-15T16:45:31Z

/hold

njhale · 2019-01-15T17:34:28Z

/lgtm cancel
/hold cancel
/test e2e-aws
/joke

openshift-ci-robot · 2019-01-15T17:34:29Z

@njhale: I really want to buy one of those supermarket checkout dividers, but the cashier keeps putting it back.

In response to this:

/lgtm cancel
/hold cancel
/test e2e-aws
/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

njhale · 2019-01-15T18:53:33Z

/test e2e-aws

jpeeler · 2019-01-15T19:20:35Z

vendor/k8s.io/client-go/pkg/version/base.go

@@ -55,8 +55,8 @@ var (
 	// NOTE: The $Format strings are replaced during 'git archive' thanks to the
 	// companion .gitattributes file containing 'export-subst' in this same
 	// directory.  See also https://git-scm.com/docs/gitattributes
-	gitVersion   string = "v0.0.0-master+$Format:%h$"
-	gitCommit    string = "$Format:%H$" // sha1 from git, output of $(git rev-parse HEAD)
+	gitVersion   string = "v0.0.0-master+7d04d0e2"


This doesn't look right.

It looks like client-go updated the way they generate version strings? What looks off to you?

I don't think it has changed? (Not sure which is the source of truth, but they are equal.)
https://github.com/kubernetes/client-go/blob/master/pkg/version/base.go#L58
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/pkg/version/base.go#L58

are we seeing the result of:

// NOTE: The $Format strings are replaced during 'git archive' thanks to the
// companion .gitattributes file containing 'export-subst' in this same
// directory. See also https://git-scm.com/docs/gitattributes

I wonder if k8s.io changed to start serving the git archive instead of the git repo?

Maybe so, will assume that's correct.

Nick's PR actually undoes the change in operator-registry, so maybe it was a mistake after all. - operator-framework/operator-registry#19.

njhale · 2019-01-15T22:23:31Z

/retest

ecordell · 2019-01-15T23:18:26Z

/retest

ecordell · 2019-01-15T23:24:24Z

/retest

njhale · 2019-01-16T12:46:36Z

/test e2e-aws-olm

ecordell · 2019-01-16T14:07:28Z

/test e2e-aws-olm

ecordell · 2019-01-16T15:08:22Z

/test e2e-aws-olm

njhale · 2019-01-16T18:20:02Z

/test e2e-aws-olm

njhale · 2019-01-17T12:14:43Z

/retest

njhale

/lgtm

and recorded on the catalogsource object. Also verifies that the pod is updated when the configmap changes.

grpc sourcetype takes a new `image` field which specifies an image which is expected to serve a registry API over grpc on port 50051.

we shouldn't process an installplan unless it has had its status set by the subscription resolver

and retrigger catalog sync if we attempt to resolve with an unhealthy catalog this should fix issues where subscriptions fail when created immedately after a catalog is updated

ecordell · 2019-01-18T14:32:38Z

/retest

ecordell · 2019-01-18T15:07:40Z

/retest

smarterclayton · 2019-01-18T16:23:50Z

/cc so I know when this merges, creates a lot of spam in the e2e runs

ecordell · 2019-01-18T16:27:07Z

/retest

njhale · 2019-01-18T16:28:17Z

/cc so I know when this merges, creates a lot of spam in the e2e runs

@smarterclayton Do all of our PRs create spam in the e2e runs?

njhale · 2019-01-18T16:30:07Z

/lgtm

openshift-ci-robot · 2019-01-18T16:30:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ecordell,njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ecordell · 2019-01-18T17:17:58Z

/retest

ecordell · 2019-01-18T18:34:54Z

/retest

…nges test(catalog): add e2e test to verify configmap changes are detected

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 15, 2019

openshift-ci-robot requested review from alecmerdler and njhale January 15, 2019 16:33

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2019

njhale reviewed Jan 15, 2019

View reviewed changes

test/e2e/catalog_e2e_test.go Outdated Show resolved Hide resolved

njhale approved these changes Jan 15, 2019

View reviewed changes

openshift-ci-robot assigned njhale Jan 15, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2019

openshift-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 15, 2019

ecordell force-pushed the configmap-changes branch from 32103ac to 68c52b7 Compare January 15, 2019 17:38

jpeeler reviewed Jan 15, 2019

View reviewed changes

ecordell force-pushed the configmap-changes branch 2 times, most recently from 32f031c to 4bc3b50 Compare January 15, 2019 19:37

ecordell force-pushed the configmap-changes branch from 4a298d2 to be8c631 Compare January 16, 2019 23:34

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 16, 2019

ecordell mentioned this pull request Jan 18, 2019

feat(catalog): add grpc sourcetype to CatalogSources #656

Closed

njhale approved these changes Jan 18, 2019

View reviewed changes

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 18, 2019

ecordell added 8 commits January 18, 2019 09:03

test(catalog): add e2e test to verify configmap changes are detected

d163546

and recorded on the catalogsource object. Also verifies that the pod is updated when the configmap changes.

fix(catalog): use a different queue for each namespace

7a5409f

fix(registry): service label selector doesn't include resourceversion

77b84ab

feat(catalog): add grpc sourcetype to CatalogSources

e8f5b41

grpc sourcetype takes a new `image` field which specifies an image which is expected to serve a registry API over grpc on port 50051.

fix(e2e): make e2e-local-docker work again

a6eafeb

fix(installplan): fix race in installplan resolution

da67b54

we shouldn't process an installplan unless it has had its status set by the subscription resolver

fix(catalogsources): omit unhealthy catalogs from resolution

723ee40

and retrigger catalog sync if we attempt to resolve with an unhealthy catalog this should fix issues where subscriptions fail when created immedately after a catalog is updated

chore(deps): vendor

e441c1d

ecordell force-pushed the configmap-changes branch from bf7ee9b to e441c1d Compare January 18, 2019 14:06

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2019

fix(test): get kube version from client go for tests

5f6282d

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2019

openshift-merge-robot merged commit f3b9375 into operator-framework:master Jan 18, 2019

ecordell deleted the configmap-changes branch January 23, 2019 13:29

ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019

Merge pull request operator-framework#670 from ecordell/configmap-cha…

7e9acef

…nges test(catalog): add e2e test to verify configmap changes are detected

njhale added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(catalog): add e2e test to verify configmap changes are detected #670

test(catalog): add e2e test to verify configmap changes are detected #670

ecordell commented Jan 15, 2019

njhale left a comment

njhale commented Jan 15, 2019

njhale commented Jan 15, 2019

openshift-ci-robot commented Jan 15, 2019

njhale commented Jan 15, 2019

jpeeler Jan 15, 2019

ecordell Jan 15, 2019

jpeeler Jan 15, 2019

ecordell Jan 15, 2019

jpeeler Jan 16, 2019

jpeeler Jan 16, 2019

njhale commented Jan 15, 2019

ecordell commented Jan 15, 2019

ecordell commented Jan 15, 2019

njhale commented Jan 16, 2019

ecordell commented Jan 16, 2019

ecordell commented Jan 16, 2019

njhale commented Jan 16, 2019

njhale commented Jan 17, 2019

njhale left a comment

ecordell commented Jan 18, 2019

ecordell commented Jan 18, 2019

smarterclayton commented Jan 18, 2019

ecordell commented Jan 18, 2019

njhale commented Jan 18, 2019 •

edited

Loading

njhale commented Jan 18, 2019

openshift-ci-robot commented Jan 18, 2019

ecordell commented Jan 18, 2019

ecordell commented Jan 18, 2019

test(catalog): add e2e test to verify configmap changes are detected #670

test(catalog): add e2e test to verify configmap changes are detected #670

Conversation

ecordell commented Jan 15, 2019

njhale left a comment

Choose a reason for hiding this comment

njhale commented Jan 15, 2019

njhale commented Jan 15, 2019

openshift-ci-robot commented Jan 15, 2019

njhale commented Jan 15, 2019

jpeeler Jan 15, 2019

Choose a reason for hiding this comment

ecordell Jan 15, 2019

Choose a reason for hiding this comment

jpeeler Jan 15, 2019

Choose a reason for hiding this comment

ecordell Jan 15, 2019

Choose a reason for hiding this comment

jpeeler Jan 16, 2019

Choose a reason for hiding this comment

jpeeler Jan 16, 2019

Choose a reason for hiding this comment

njhale commented Jan 15, 2019

ecordell commented Jan 15, 2019

ecordell commented Jan 15, 2019

njhale commented Jan 16, 2019

ecordell commented Jan 16, 2019

ecordell commented Jan 16, 2019

njhale commented Jan 16, 2019

njhale commented Jan 17, 2019

njhale left a comment

Choose a reason for hiding this comment

ecordell commented Jan 18, 2019

ecordell commented Jan 18, 2019

smarterclayton commented Jan 18, 2019

ecordell commented Jan 18, 2019

njhale commented Jan 18, 2019 • edited Loading

njhale commented Jan 18, 2019

openshift-ci-robot commented Jan 18, 2019

ecordell commented Jan 18, 2019

ecordell commented Jan 18, 2019

njhale commented Jan 18, 2019 •

edited

Loading