Replace Polling with Watching in E2E Tests

[alecmerdler]

Description

Advantages of .Watch() over polling:

• Can catch extra API calls by counting the number of Modify events before we see the status we want
• Faster tests
• Less test logging noise

Addresses https://jira.coreos.com/browse/ALM-885

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alecmerdler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ecordell]

This looks good! Holding off the the lgtm because there are lots of small notes to change things still, just let me know when it's ready for a review

[openshift-ci-robot]

@alecmerdler: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-olm	200313f	link	/test e2e-aws-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[njhale]

@ecordell I think this is super valuable, but IIRC we decided that we were going to use watches for all new e2e tests and replace older tests as we drop support for the v1 APIs. If that is the case, should we close this?

[ecordell]

@njhale seems reasonable to me