Make e2e more robust #703
Merged
Make e2e more robust #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 7, 2019 15:55
TestCreateNewSubscriptionExistingCSV was occasionally flaking due to cleanupOLM not actually immediately deleting resources and initCatalog assuming that if a resource already existed that it would remain. My editor also cleaned up a lot of whitespacing in subscription_e2e_test.go.
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
|
/test e2e-aws |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alecmerdler, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
Make e2e more robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are commits that I had to make in order to make #675 pass reliably. Since that PR is going to be delayed to allow more important operator group fixes in, go ahead and merge this.
Hoping that it'll help @dinhxuanvu with some of his e2e woes.