Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove minishift support #704

Merged
merged 1 commit into from
Mar 10, 2019
Merged

remove minishift support #704

merged 1 commit into from
Mar 10, 2019

Conversation

leseb
Copy link
Contributor

@leseb leseb commented Feb 8, 2019 •
edited
Loading

As per #705 (comment) it has been decided to drop support for minishift.

Signed-off-by: Sébastien Han seb@redhat.com

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2019
@njhale
Copy link
Member

njhale commented Feb 12, 2019

@leseb These are good changes, but as we discussed in #705 we want to move away from minishift altogether. make run-local uses minikube and builds with upstream.Dockerfile which copies the required git objects into the image. If we can repurpose this PR to remove the minishift stuff, that would be incredibly helpful - up to you.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2019
@leseb
Copy link
Contributor Author

leseb commented Feb 13, 2019

@njhale done!

@ecordell
Copy link
Member

ecordell commented Feb 18, 2019 •
edited
Loading

@leseb - we intentionally omitted the git objects to limit the size of our build context. Our other dockerfiles copy enough of the git repo so that git rev-parse HEAD works, I think we just missed this one.

@leseb
Copy link
Contributor Author

leseb commented Feb 18, 2019

@ecordell I haven't tried again without minishift so I was just assuming this bug was on the other Dockerfile too. Thanks for commenting, let me remove that commit then.

@leseb leseb changed the title dockerignore: do not ignore git objects remove minishift support Feb 18, 2019
@njhale
Copy link
Member

njhale commented Feb 18, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 18, 2019
@ecordell
Copy link
Member

Thanks for this! Could you also remove e2e-local-shift from the Makefile?

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2019
@leseb
remove minishift support
6a7991d 
As per
operator-framework#705 (comment)
it has been decided to drop support for minishift.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb
Copy link
Contributor Author

leseb commented Feb 18, 2019 •
edited
Loading

@ecordell done!

@leseb
Copy link
Contributor Author

leseb commented Feb 19, 2019

I believe CI's failure is unrelated to that patch, isn't?

@njhale
Copy link
Member

njhale commented Feb 21, 2019

/retest

@njhale
Copy link
Member

njhale commented Feb 27, 2019

/test e2e-aws

@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, leseb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpeeler
Copy link

jpeeler commented Mar 5, 2019

/retest

2 similar comments
@njhale
Copy link
Member

njhale commented Mar 8, 2019

/retest

@njhale
Copy link
Member

njhale commented Mar 9, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit a196e4e into operator-framework:master Mar 10, 2019
@ecordell ecordell added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell Awaiting requested review from ecordell

@njhale njhale Awaiting requested review from njhale

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@leseb @njhale @ecordell @openshift-ci-robot @jpeeler @openshift-merge-robot