Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csv): remove regex on base64 image data #723

Merged

Conversation

ecordell
Copy link
Member

No description provided.

Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alecmerdler,ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2019
@ecordell ecordell closed this Feb 23, 2019
@ecordell ecordell reopened this Feb 23, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 23, 2019
@operator-framework operator-framework deleted a comment from ecordell Feb 23, 2019
@operator-framework operator-framework deleted a comment from ecordell Feb 23, 2019
@spadgett
Copy link
Contributor

/retest

4 similar comments
@spadgett
Copy link
Contributor

/retest

@spadgett
Copy link
Contributor

/retest

@ecordell
Copy link
Member Author

/retest

@spadgett
Copy link
Contributor

/retest

@spadgett
Copy link
Contributor

cadvisor flake again :(

/retest

@njhale
Copy link
Member

njhale commented Feb 24, 2019

/restest

@njhale njhale closed this Feb 24, 2019
@njhale njhale reopened this Feb 24, 2019
@spadgett
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit 1e46215 into operator-framework:master Feb 24, 2019
@ecordell ecordell deleted the remove-regex branch February 24, 2019 16:58
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
fix(csv): remove regex on base64 image data
@ecordell ecordell removed kind/bug Categorizes issue or PR as related to a bug. labels Mar 19, 2019
@ecordell ecordell added kind/bug Categorizes issue or PR as related to a bug. and removed kind/bug Categorizes issue or PR as related to a bug. labels Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants