-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minKubeVersion validation to templates #739
Add minKubeVersion validation to templates #739
Conversation
deploy/ocp/manifests/0.8.1/0000_50_olm_02-clusterserviceversion.crd.yaml
Outdated
Show resolved
Hide resolved
647019c
to
0845433
Compare
@njhale Would you mind taking a look? |
/test e2e-aws-olm |
1 similar comment
/test e2e-aws-olm |
@dinhxuanvu Looks like you're hitting an issue with the new
I opened #744 to fix the problem. |
Require minKubeVersion to be SemVer formated (Major.Minor.Patch). Signed-off-by: Vu Dinh <vdinh@redhat.com>
e8e7374
to
49f615b
Compare
Add pattern validation for minKubeVersion across all templates.
Sweet, this looks great! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Require minKubeVersion to be SemVer formated (Major.Minor.Patch).
Signed-off-by: Vu Dinh vdinh@redhat.com