Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minKubeVersion validation to templates #739

Merged

Conversation

dinhxuanvu
Copy link
Member

Require minKubeVersion to be SemVer formated (Major.Minor.Patch).

Signed-off-by: Vu Dinh vdinh@redhat.com

deploy/upstream/values.yaml Outdated Show resolved Hide resolved
@dinhxuanvu dinhxuanvu force-pushed the minkube-validation branch from 647019c to 0845433 Compare March 5, 2019 21:26
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2019
@dinhxuanvu
Copy link
Member Author

@njhale Would you mind taking a look?

@dinhxuanvu
Copy link
Member Author

/test e2e-aws-olm

1 similar comment
@dinhxuanvu
Copy link
Member Author

/test e2e-aws-olm

@njhale
Copy link
Member

njhale commented Mar 7, 2019

@dinhxuanvu Looks like you're hitting an issue with the new anyOf validation:


Error Trace:	operator_groups_e2e_test.go:566
Error:      	Received unexpected error:
     OperatorGroup.operators.coreos.com "a9kv25" is invalid: []: Invalid value: map[string]interface {}{"metadata":map[string]interface {}{"name":"a9kv25", "namespace":"aqdbpn", "creationTimestamp":"2019-03-06T21:54:10Z", "generation":1, "uid":"5f51b529-405a-11e9-a7cb-0e3b49dab7a4"}, "spec":map[string]interface {}{"selector":map[string]interface {}{}, "serviceAccount":map[string]interface {}{"metadata":map[string]interface {}{"creationTimestamp":interface {}(nil)}}}, "kind":"OperatorGroup", "apiVersion":"operators.coreos.com/v1alpha2"}: validation failure list:
			       must validate at least one schema (anyOf)
			       spec.selector.matchLabels in body is required
Test:       	TestOperatorGroupIntersection

I opened #744 to fix the problem.

Require minKubeVersion to be SemVer formated (Major.Minor.Patch).

Signed-off-by: Vu Dinh <vdinh@redhat.com>
@dinhxuanvu dinhxuanvu force-pushed the minkube-validation branch from e8e7374 to 49f615b Compare March 8, 2019 00:17
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 8, 2019
Add pattern validation for minKubeVersion across all templates.
@njhale
Copy link
Member

njhale commented Mar 8, 2019

Sweet, this looks great!
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2019
@njhale
Copy link
Member

njhale commented Mar 8, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2019
@openshift-merge-robot openshift-merge-robot merged commit a6c0fe7 into operator-framework:master Mar 8, 2019
@ecordell ecordell removed kind/bug Categorizes issue or PR as related to a bug. labels Mar 19, 2019
@njhale njhale added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants