Subscription steps through multiple upgrades #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
step through multiple intermediate versions we have tests for this for CSVs, but not one for subscriptions.
this prevents detecting two updates to the same operator during one resolution
the test was previously asserting that we would resolve a subscription for an existing csv, which is wrong. if the csv exists in the cluster, we leave it alone (but still consider it's depended/provided apis when resolviing).
openshift-ci-robot
added
approved
|
/test e2e-aws-olm |
|
/retest |
|
/test e2e-aws-olm |
ecordell
force-pushed
the
multiple-upgrades
branch
2 times, most recently
from
5b6ba86 to
36d470a
Compare
ecordell
force-pushed
the
multiple-upgrades
branch
from
36d470a to
c18727b
Compare
ownerlabel for roles/rolebindings were missing the kind label, which is used in the selector to determine which roles/bindings are owned by the operator. this fixes a bug where roles/rolebindings would not be lifted to clusterroles/bindings when installed into a global operatorgroup
yet been created this should prevent some churn and possible races
ecordell
force-pushed
the
multiple-upgrades
branch
from
c18727b to
3e1ca71
Compare
jpeeler
reviewed
Mar 17, 2019
| @@ -140,10 +140,12 @@ func (o *Operator) Run(stopc <-chan struct{}) (ready, done chan struct{}, atLeve | |||
| o.Log.Info("starting workers...") | |||
| for _, queueInformer := range o.queueInformers { | |||
| go o.worker(queueInformer) | |||
| go o.worker(queueInformer) | |||
| } | |||
There was a problem hiding this comment.
Why is this addition and below necessary?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ecordell
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls out a subset of commits from #756 that omits the additional guards around when we attempt to update (they had farther reaching effects that will take a while to test/verify).