Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(annotation): don't annotate deployments that aren't owned by a CSV #792

Merged
merged 1 commit into from
Mar 29, 2019
Merged

fix(annotation): don't annotate deployments that aren't owned by a CSV #792

merged 1 commit into from
Mar 29, 2019

Conversation

ecordell
Copy link
Member

@ecordell ecordell commented Mar 28, 2019 •
edited
Loading

Previously this was inadvertently annotating all deployments in a namespace. It now finds deployments via the CSV owner selector.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2019
@ecordell ecordell force-pushed the fix-deploy-annotation branch from af46eef to ec6504d Compare March 28, 2019 22:57
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2019
@ecordell
Copy link
Member Author

/test unit

@njhale njhale added the kind/bug Categorizes issue or PR as related to a bug. label Mar 28, 2019
@njhale njhale force-pushed the fix-deploy-annotation branch from ec6504d to 94fd8fb Compare March 29, 2019 01:42
@dmesser
Copy link
Contributor

dmesser commented Mar 29, 2019

/test unit

njhale
njhale approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 836d963 into operator-framework:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhale njhale njhale approved these changes

@jpeeler jpeeler Awaiting requested review from jpeeler

Assignees

@njhale njhale

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ecordell @dmesser @openshift-ci-robot @njhale @openshift-merge-robot