Update Kubernetes dependencies to 1.12.7 #793
Conversation
go mod vendor
go get github.com/evanphx/json-patch@master
openshift-ci-robot
added
approved
|
/retest |
|
I managed to get the items in the replace block down to three things - logrus, client-go, and api. However, that makes less sense to me than doing what was done here since everything here is permanently in sync and will therefore not break. The impossible behavior I've observed is that when client-go is fetched, it pulls in the latest k8s.io/api. Fetching other kubernetes dependencies (for whatever reason) downgrades client-go to the previous release. Both of which causes things to break and is why pinning both of them seemed to be absolutely necessary. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Need to discuss if this is a valid approach. I've not been able to make
go getdownload the desired versions without using replace in go.mod. I assume this is because of all the weird non-semver tagging in play. If using replace is okay, then it's probably best to remove the makefile vendoring stuff as it does not work well with the changes here.The good news is that the necessary changes due to updating were very minimal. One benefit to keeping the dependencies aligned this way is that there won't be go.* file changes during normal OLM development.
OLM-892