-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the git add issue #798
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jianzhangbjz If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-olm |
|
I don't think this PR is correct, though it's clear that somehow something got out of sync based on your git status output. The lower case version of logrus (github.com/sirupsen/logrus) should be at v1.2.0 while the upper case version (github.com/Sirupsen/logrus) should be at v1.1.0. This PR is changing the lower case version to v1.1.0. Are you still seeing this issue on a fresh clone? This is so close to the recent rebase (March 28th) that I'm wondering if that is somehow related. |
@jianzhangbjz @jpeeler It looks like this is an issue with case sensitivity and git on OSX - in this case around @jianzhangbjz If you're on OSX and you find yourself unable to check out the latest remote OLM due to the issue, you can run something like |
@jpeeler @njhale Sorry for the late to reply. Many thanks for your suggestions! It works now by following the below steps: $ git fetch --all
$ git rm -rf vendor
$ git commit -m "throw away xxx"
$ git reset --hard origin/master
mac:operator-lifecycle-manager jianzhang$ git status
On branch master
Your branch is up to date with 'origin/master'.
nothing to commit, working tree clean
mac:operator-lifecycle-manager jianzhang$ git log
commit 33ccf629ecf1aa0f46a0acf7875fe97a37d5e499 (HEAD -> master, origin/release-4.1, origin/release-4.0, origin/master, origin/HEAD)
Merge: 4de8dd1a ab2f6721
Author: OpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com>
Date: Sat Apr 13 17:26:53 2019 -0700
Merge pull request #811 from ecordell/progressing-timestamp
chore(cvo): report progressing=true if the version has updated
... |
Fix #797, steps as below, @ecordell @njhale Correct me if I'm wrong.