Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cvo): report progressing=true if the version has updated #811

Conversation

ecordell
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 12, 2019
@ecordell
Copy link
Member Author

/retest

3 similar comments
@ecordell
Copy link
Member Author

/retest

@ecordell
Copy link
Member Author

/retest

@ecordell
Copy link
Member Author

/retest

},
{
Name: "operator-lifecycle-manager",
Version: olmversion.OLMVersion,
},
}
if targetOperatorVersion != previousOperatorVersion {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check my understanding - on cluster init, previousOperatorVersion should be "0.0.1-snapshot" here, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be, yes

@njhale
Copy link
Member

njhale commented Apr 12, 2019

/retest

4 similar comments
@ecordell
Copy link
Member Author

/retest

@ecordell
Copy link
Member Author

/retest

@njhale
Copy link
Member

njhale commented Apr 13, 2019

/retest

@ecordell
Copy link
Member Author

/retest

Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ecordell
Copy link
Member Author

/retest

5 similar comments
@ecordell
Copy link
Member Author

/retest

@ecordell
Copy link
Member Author

/retest

@ecordell
Copy link
Member Author

/retest

@ecordell
Copy link
Member Author

/retest

@ecordell
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 33ccf62 into operator-framework:master Apr 14, 2019
dinhxuanvu pushed a commit to dinhxuanvu/operator-lifecycle-manager that referenced this pull request Apr 17, 2019
…imestamp

chore(cvo): report progressing=true if the version has updated
dinhxuanvu pushed a commit to dinhxuanvu/operator-lifecycle-manager that referenced this pull request Apr 17, 2019
…imestamp

chore(cvo): report progressing=true if the version has updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants