Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription Status InstallPlan References #820

Merged
merged 3 commits into from
Apr 24, 2019

Conversation

njhale
Copy link
Member

@njhale njhale commented Apr 19, 2019

Adds InstallPlan ObjectReferences to SubscriptionStatus and cleans up unit test configuration.

This is the first part in implementing the improved subscription status proposal.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 19, 2019
@ecordell
Copy link
Member

closing / reopening to run the console tests

@ecordell ecordell closed this Apr 22, 2019
@ecordell ecordell reopened this Apr 22, 2019
@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@njhale
Copy link
Member Author

njhale commented Apr 23, 2019

/retest

4 similar comments
@njhale
Copy link
Member Author

njhale commented Apr 23, 2019

/retest

@ecordell
Copy link
Member

/retest

@ecordell
Copy link
Member

/retest

@njhale
Copy link
Member Author

njhale commented Apr 23, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit b8b77a1 into operator-framework:master Apr 24, 2019
@njhale njhale deleted the sub-ip-ref branch September 30, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants