Fix gRPC registry pod recreation #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add k8s fake client decorator - Add shared options for k8s and olm decorators - Add simple name generator option
- Use fake k8s decorator for reconciler tests - Consolidate fake reconciler factory constructors - Add gRPC registry pod check unit tests - Refactor gRPC registry pod reconcile unit tests
openshift-ci-robot
added
the
size/XL
openshift-ci-robot
added
the
approved
|
/retest |
|
/retest |
|
/hold There's an issue with one of the postfix constant. Will fix. |
openshift-ci-robot
added
the
do-not-merge/hold
njhale
commented
May 1, 2019
njhale
commented
May 1, 2019
njhale
force-pushed
the
fix-registry-recreation
branch
from
6704eb6 to
8b9100d
Compare
njhale
force-pushed
the
fix-registry-recreation
branch
from
8b9100d to
5fff1e9
Compare
|
/hold cancel Fixed the resource name postfixes. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws |
|
/test e2e-aws-olm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses fixes deleted gRPC registry pod recreation; the other half of OLM-902.
internalcatalog resourcesThis steals some test tools from #816 (e.g. k8s fake client decorator, simple name generator option)