Bug 1746054: Set limit on length of Status.Conditions of a csv #836
Conversation
openshift-ci-robot
added
the
size/L
|
/test unit |
| @@ -282,3 +284,111 @@ func TestSupports(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestSetPhaseWithConditionsLengthAtLimit(t *testing.T) { | |||
There was a problem hiding this comment.
These tests look good, but we try to keep a consistent style for tests. Generally we do a "table-driven" test style, where each test case defines expected inputs/outputs.
So for these tests, that would look something like
func TestSetPhaseLengthLimits() {
tests := []struct{
name string
currentConditions []conditions
args args
expected expected
} {
// an instance for each test case
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// set csv conditions to tt.currentConditions
// call csv.SetPhase(args)
// check csv conditions == expected
}
}There was a problem hiding this comment.
@ecordell converted to table driven, it looks concise and more readable now. Can you take a look?
Set a maximum length of Status.Conditions of ClusterServiceVersion object(s). The oldest condition(s) should be removed from the list as it grows over time to keep it at limit. The default limit is set to 20. Jira: https://jira.coreos.com/browse/OLM-963
tkashem
force-pushed
the
csv-conditions-length
branch
from
c4f83e1 to
af2a3b3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test e2e-aws-olm |
1 similar comment
|
/test e2e-aws-olm |
|
/retest |
|
/test e2e-aws-olm |
1 similar comment
|
/test e2e-aws-olm |
ecordell
changed the title
|
@tkashem: All pull requests linked via external trackers have merged. Bugzilla bug 1746054 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Set a maximum length of Status.Conditions of ClusterServiceVersion
object(s). The oldest condition(s) should be removed from the list
as it grows over time to keep it at limit.
The default limit is set to 20.
Jira: https://jira.coreos.com/browse/OLM-963