Allow CRD updates with multiple owners #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
jpeeler
force-pushed
the
crd-schema-change
branch
from
8d70ee7 to
1b6816f
Compare
|
This looks good but waiting on #878 ! |
openshift-ci-robot
added
the
needs-rebase
jpeeler
force-pushed
the
crd-schema-change
branch
from
1b6816f to
e733473
Compare
openshift-ci-robot
removed
the
needs-rebase
|
/retest |
ecordell
reviewed
Jun 24, 2019
jpeeler
force-pushed
the
crd-schema-change
branch
from
e733473 to
7576f79
Compare
openshift-ci-robot
added
size/L
ecordell
reviewed
Jun 26, 2019
jpeeler
force-pushed
the
crd-schema-change
branch
from
7576f79 to
3470dea
Compare
|
/retest |
|
/test e2e-aws-upgrade |
1 similar comment
|
/test e2e-aws-upgrade |
jpeeler
commented
Jul 1, 2019
ecordell
reviewed
Jul 1, 2019
Currently CRD updates aren't done for existing CRDs, so this enables that functionality in the cases of: - New CRD is a different non-existing version - New CRD is the same version without an openapi schema change
jpeeler
force-pushed
the
crd-schema-change
branch
from
3470dea to
b5fde62
Compare
|
/test unit |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to allow CRD updates for existing CRDs, which isn't currently done. This enables that functionality in the cases of:
This is rebased on top of #878, so that should merge first.