Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a target for compiling bare e2e #921

Merged

Conversation

jpeeler
Copy link

@jpeeler jpeeler commented Jun 20, 2019

This is just an idea of how to do this and will likely not go in.

Initially I tried using the $(CMDS) target, refactored it, and then ended up leaving it since it looked simpler. But maybe it's not worth changing...

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 20, 2019
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

There is probably a better way to use make for this, but since this solves a real problem now I say let's merge and look at it more later.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, jpeeler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpeeler
Copy link
Author

jpeeler commented Jun 28, 2019

/retest
Ok given this is going in, we still have to call the new make target somewhere to make breakage show up. I didn't add it to any of the existing targets here and I don't think it should be really.

@njhale
Copy link
Member

njhale commented Jun 29, 2019

/retest

1 similar comment
@jpeeler
Copy link
Author

jpeeler commented Jun 29, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 9f8506c into operator-framework:master Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants