Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): remove extra resource comparison #938

Merged
merged 1 commit into from
Jul 2, 2019
Merged

test(e2e): remove extra resource comparison #938

merged 1 commit into from
Jul 2, 2019

Conversation

njhale
Copy link
Member

@njhale njhale commented Jul 1, 2019

Remove extra resource comparison at the end of two tests since
eventually consistent orthogonal conditions sometimes cause a false
negative.

@njhale
test(e2e): remove extra resource comparison
f09b563 
Remove extra resource comparison at the end of two tests since
eventually consistent orthogonal conditions sometimes cause a false
negative.
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2019
@njhale
Copy link
Member Author

njhale commented Jul 1, 2019

/retest

alecmerdler
alecmerdler approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2019
@jpeeler
Copy link

jpeeler commented Jul 1, 2019

/lgtm
Honestly I wondered why this was here and need to remove it from some of my copy/pasting.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, jpeeler, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alecmerdler,jpeeler,njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alecmerdler
Copy link
Member

I had added these long ago to catch runaway OLM control loops causing the UI to break (impossible to update a resource using YAML editor). We can catch unnecessary updates to objects using the Watch() PR once that is merged.

@njhale
Copy link
Member Author

njhale commented Jul 1, 2019

/retest

1 similar comment
@njhale
Copy link
Member Author

njhale commented Jul 1, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 2bd381f into operator-framework:master Jul 2, 2019
@njhale njhale deleted the remove-extra-comparison branch September 30, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler alecmerdler approved these changes

@jpeeler jpeeler Awaiting requested review from jpeeler

Assignees

@jpeeler jpeeler

@alecmerdler alecmerdler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@njhale @jpeeler @openshift-ci-robot @alecmerdler @openshift-merge-robot