-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple benchmark for namespaced subscription resolution #943
Add simple benchmark for namespaced subscription resolution #943
Conversation
9145945
to
c5cc5a2
Compare
Cool idea. What do you think about adding in a generous threshold that triggers failure? |
/retest |
c5cc5a2
to
3811c45
Compare
/lgtm |
3811c45
to
f41dccb
Compare
/retest |
1 similar comment
/retest |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, jpeeler, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, jpeeler, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
2 similar comments
/retest |
/retest |
Adds a simple benchmark test for the
syncResolvingNamespace
method.I initially made this to catch some memory utilization issues, but thought it could also be useful as a reference for other benchmarks we may write.