Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple benchmark for namespaced subscription resolution #943

Merged

Conversation

njhale
Copy link
Member

@njhale njhale commented Jul 4, 2019

Adds a simple benchmark test for the syncResolvingNamespace method.

I initially made this to catch some memory utilization issues, but thought it could also be useful as a reference for other benchmarks we may write.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2019
@njhale njhale force-pushed the catalog-benchmarks branch from 9145945 to c5cc5a2 Compare July 5, 2019 18:03
@jpeeler
Copy link

jpeeler commented Jul 5, 2019

Cool idea. What do you think about adding in a generous threshold that triggers failure?

@njhale
Copy link
Member Author

njhale commented Jul 5, 2019

/retest

@njhale njhale force-pushed the catalog-benchmarks branch from c5cc5a2 to 3811c45 Compare July 5, 2019 19:12
@jpeeler
Copy link

jpeeler commented Jul 5, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2019
@njhale njhale force-pushed the catalog-benchmarks branch from 3811c45 to f41dccb Compare July 5, 2019 19:53
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2019
@njhale
Copy link
Member Author

njhale commented Jul 5, 2019

/retest

1 similar comment
@njhale
Copy link
Member Author

njhale commented Jul 8, 2019

/retest

@ecordell
Copy link
Member

ecordell commented Jul 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019
@jpeeler
Copy link

jpeeler commented Jul 8, 2019

/lgtm
Just a timeout change since I last looked over it.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, jpeeler, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ecordell,jpeeler,njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, jpeeler, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ecordell,jpeeler,njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@njhale
Copy link
Member Author

njhale commented Jul 8, 2019

/retest

2 similar comments
@njhale
Copy link
Member Author

njhale commented Jul 9, 2019

/retest

@njhale
Copy link
Member Author

njhale commented Jul 9, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit d4505e7 into operator-framework:master Jul 9, 2019
@njhale njhale deleted the catalog-benchmarks branch September 30, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants