Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1746270: Remove deprecated CRD's stored versions to allow CRD update #983

Merged
merged 2 commits into from
Sep 10, 2019
Merged

Bug 1746270: Remove deprecated CRD's stored versions to allow CRD update #983

merged 2 commits into from
Sep 10, 2019

Conversation

dinhxuanvu
Copy link
Member

Attempt to remove deprecated CRD versions from stored versions in
current CRD. Then, the CRD update can be proceeded.

Signed-off-by: Vu Dinh vdinh@redhat.com

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 15, 2019
@dinhxuanvu dinhxuanvu mentioned this pull request Aug 15, 2019
Merged
ecordell
ecordell reviewed Aug 16, 2019
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! just a couple of nits.

pkg/controller/operators/catalog/operator.go Outdated Show resolved Hide resolved
pkg/controller/operators/catalog/operator.go Outdated Show resolved Hide resolved
pkg/controller/operators/catalog/operator.go Outdated Show resolved Hide resolved
@dinhxuanvu dinhxuanvu force-pushed the removeDeprecated branch 2 times, most recently from 7a79ab0 to 8f7a200 Compare August 16, 2019 14:23
@ecordell
Copy link
Member

/retest

@jpeeler
Copy link

jpeeler commented Aug 16, 2019 •
edited
Loading

That unit test failure is real. Or I guess it was a flake after all...

@jpeeler
Copy link

jpeeler commented Aug 16, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2019
@jpeeler
Copy link

jpeeler commented Aug 16, 2019

/approved

@jpeeler
Copy link

jpeeler commented Aug 16, 2019

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2019
@dinhxuanvu
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2019
@dinhxuanvu
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2019
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu dinhxuanvu force-pushed the removeDeprecated branch 3 times, most recently from 9248768 to 608e778 Compare September 3, 2019 20:15
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu dinhxuanvu force-pushed the removeDeprecated branch 2 times, most recently from e0fc91d to 9479ab9 Compare September 5, 2019 12:00
@dinhxuanvu
Copy link
Member Author

/retest

1 similar comment
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu dinhxuanvu force-pushed the removeDeprecated branch 3 times, most recently from abdef70 to 1e74c13 Compare September 6, 2019 04:15
@dinhxuanvu
Add unit and e2e test cases for deprecating a CRD version
4bb8526 
Fix some minor issues in test suite.

Signed-off-by: Vu Dinh <vdinh@redhat.com>
@jpeeler
Copy link

jpeeler commented Sep 6, 2019

/retest

@dinhxuanvu dinhxuanvu changed the title Remove deprecated CRD's stored versions to allow CRD update Bug 1746270: Remove deprecated CRD's stored versions to allow CRD update Sep 6, 2019
@openshift-ci-robot
Copy link
Collaborator

@dinhxuanvu: This pull request references Bugzilla bug 1746270, which is valid.

In response to this:

Bug 1746270: Remove deprecated CRD's stored versions to allow CRD update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 6, 2019
@dinhxuanvu
Copy link
Member Author

/retest

7 similar comments
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@jpeeler
Copy link

jpeeler commented Sep 10, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, jpeeler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 95572bc into operator-framework:master Sep 10, 2019
@openshift-ci-robot
Copy link
Collaborator

@dinhxuanvu: All pull requests linked via external trackers have merged. Bugzilla bug 1746270 has been moved to the MODIFIED state.

In response to this:

Bug 1746270: Remove deprecated CRD's stored versions to allow CRD update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeeler jpeeler jpeeler left review comments

@ecordell ecordell ecordell left review comments

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

Assignees

@jpeeler jpeeler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. CRD Versioning lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dinhxuanvu @ecordell @jpeeler @openshift-ci-robot @openshift-merge-robot