Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix name of dir - replace Documentation for doc #992

Merged
merged 1 commit into from
Sep 5, 2019
Merged

fix name of dir - replace Documentation for doc #992

merged 1 commit into from
Sep 5, 2019

Conversation

camilamacedo86
Copy link
Contributor

WHAT

  • Rename the dir "Documentation" for "doc"

WHY

  • Following the org standard
  • It should not start with uppercase.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 19, 2019
@openshift-ci-robot
Copy link
Collaborator

Hi @camilamacedo86. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2019
@ecordell
Copy link
Member

/approve
/lgtm

This is great - the only reason we had it Documentation in the first place was due to tooling requirements.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 20, 2019
@ecordell
Copy link
Member

/ok-to-test

sorry, I think we have a conflict from proposals that merged

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2019
@camilamacedo86
Copy link
Contributor Author

Hi @ecordell,

It is rebased with the master now. Could we merge it now?

@camilamacedo86
Copy link
Contributor Author

Hi @ecordell,

It is rebased with the master, could we merge it now?

@ecordell
Copy link
Member

ecordell commented Sep 4, 2019

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ecordell
Copy link
Member

ecordell commented Sep 4, 2019

/retest

@ecordell
Copy link
Member

ecordell commented Sep 5, 2019

@camilamacedo86 It looks like your last pr causes a conflict with this one - would you mind rebasing?

@openshift-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2019
@camilamacedo86
Copy link
Contributor Author

Hi @ecordell done :-)

@openshift-ci-robot
Copy link
Collaborator

@camilamacedo86: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 1cb0681 link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ecordell
Copy link
Member

ecordell commented Sep 5, 2019

doc only - merge

@ecordell ecordell merged commit 85375dd into operator-framework:master Sep 5, 2019
@camilamacedo86 camilamacedo86 deleted the fix-doc branch September 5, 2019 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants