Modify API to return empty struct instead of error while querrying em…

…pty bundle
operator-framework · Oct 16, 2019 · 4a3ec14 · 4a3ec14
1 parent 5956404
commit 4a3ec14
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/pkg/server/server.go b/pkg/server/server.go
@@ -43,6 +43,11 @@ func (s *RegistryServer) GetBundle(ctx context.Context, req *api.GetBundleReques
 	if err != nil {
 		return nil, err
 	}
+	// if the value of the `bundle` field in the OperatorBundle table is NULL, return an
+	// empty Bundle struct
+	if bundleString == "" {
+		return new(api.Bundle), nil
+	}
 	entry := &registry.ChannelEntry{
 		PackageName: req.GetPkgName(),
 		ChannelName: req.GetChannelName(),

diff --git a/pkg/sqlite/query.go b/pkg/sqlite/query.go
@@ -113,7 +113,7 @@ func (s *SQLQuerier) GetBundle(ctx context.Context, pkgName, channelName, csvNam
 	}
 
 	if !rows.Next() {
-		return "", fmt.Errorf("no bundle found for csv %s", csvName)
+		return "", fmt.Errorf("no entry found for csv %s", csvName)
 	}
 	var bundleStringSQL sql.NullString
 	if err := rows.Scan(&bundleStringSQL); err != nil {