-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor directory is checked into github #202
Comments
I think this is a totally reasonable change, but unfortunately it's going to require more significant work than just removing this repo's vendor folder and getting the local build working. Today the operator-registry along with several other projects in the operator-framework are tied into and published as part of OpenShift. Today, that integration requires that the There is an active effort around getting that upstream/downstream split started (sounds like in the next month or so? Not sure on the timeline exactly). Once that happens, the steps to getting a pr like that merged will be much simpler. In the meantime, if you want to just submit a PR that includes the vendor folder diff, I think that would be reasonable. |
Thanks @kevinrizza |
Update operator-framework/api dependency to include a new constraint type (operator-framework#202). Signed-off-by: Vu Dinh <vudinh@outlook.com>
Update operator-framework/api dependency to include a new constraint type (#202). Signed-off-by: Vu Dinh <vudinh@outlook.com>
Hi, I'm currently working on removing the un-necessary pinned versions from go.mod (see #201)
I have the code working on my local branch but because the vendor directory is checked-in, the size of my PR would be 3k lines.
I believe the best practices recommend to have the vendor directory outside of the repo as go.mod and go.sum provide the locked-in version without having to maintain the vendor directory in the repo
The text was updated successfully, but these errors were encountered: