-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image digests for referencing bundles #103
Image digests for referencing bundles #103
Conversation
ef4bb48
to
9b74e52
Compare
@ecordell @kevinrizza I've rebased it on top of #101. PTAL |
9b74e52
to
d48ff71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great - can you add positive tests for the grpc apis (i.e. if bundle = nil and bundlepath = path in the db, the grpc apis return the right thing)?
pkg/sqlite/migrations.go
Outdated
@@ -0,0 +1,310 @@ | |||
// Code generated by go-bindata. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can delete this
- Change schema of OperatorBundle to include field 'bundlepath' - Extend GetBundle API to return bundle image path - Modify GetBundle API to return struct with avaiable fields instead of error while querrying empty bundles
d48ff71
to
748192e
Compare
@ecordell looks like there's two ways we can add this test with the way the tests are laid out now:
There is also a third option: Write a test that creates a database and populates it with the information that we need to query, but I feel that'll just be dead code soon. What do we think is our preference here? |
/lgtm That's fine, we can come back with tests after #89 merges |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of the change:
instead of error while querrying empty bundles
Reviewer Checklist
/docs