-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPECO-2664: rename veneer to template #1066
OPECO-2664: rename veneer to template #1066
Conversation
@grokspawn: This pull request references OPECO-2664 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
50d2bee
to
da0e879
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, oceanc80 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
…g temp skips of failing utests until we get the new release Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
} | ||
|
||
testCases := []testCase{ | ||
{ | ||
skipme: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a temporary flag to skip basic/semver tests which currently fail because they depend on an image which has the updated naming, but we cannot publish a new image until we merge this PR.
Immediately after the PR merges we'll cut a release and create a new PR to remove this mechanism and any failures it hides.
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
==========================================
- Coverage 52.76% 52.15% -0.62%
==========================================
Files 106 106
Lines 9375 9378 +3
==========================================
- Hits 4947 4891 -56
- Misses 3515 3573 +58
- Partials 913 914 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@grokspawn: This pull request references OPECO-2664 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
Description of the change:
Renaming all references from veneer to template. Catalog Template is now the accepted term, and this just enforces all code references to be consistent.
Along the way, we discovered that
Motivation for the change:
Reviewer Checklist
/docs