OPECO-2664: rename veneer to template

[grokspawn]

Description of the change:
Renaming all references from veneer to template. Catalog Template is now the accepted term, and this just enforces all code references to be consistent.

Along the way, we discovered that

• cobra command hierarchies will only exit with non-zero status if there is an unbroken chain of provided Run[E] functions from parent to child, so this includes some empty Run methods to preserve this chain
• the base image for opm to render fragments from composite template does not support the name-change, but we have to merge this PR to be able to release an image which will, so this includes temporary skips of utests which were failing due to the image dependency.

Motivation for the change:

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

[openshift-ci-robot]

@grokspawn: This pull request references OPECO-2664 which is a valid jira issue.

In response to this:

Description of the change:
Renaming all references from veneer to template. Catalog Template is now the accepted term, and this just enforces all code references to be consistent.

Motivation for the change:

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, oceanc80

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [grokspawn,oceanc80]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oceanc80]

/lgtm

[grokspawn]

Adding a temporary flag to skip basic/semver tests which currently fail because they depend on an image which has the updated naming, but we cannot publish a new image until we merge this PR.

Immediately after the PR merges we'll cut a release and create a new PR to remove this mechanism and any failures it hides.

[codecov]

Codecov Report

Merging #1066 (1209d7e) into master (67e6777) will decrease coverage by 0.62%.
The diff coverage is 51.11%.

❗ Current head 1209d7e differs from pull request most recent head b47d888. Consider uploading reports for the commit b47d888 to get more accurate results

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
- Coverage   52.76%   52.15%   -0.62%     
==========================================
  Files         106      106              
  Lines        9375     9378       +3     
==========================================
- Hits         4947     4891      -56     
- Misses       3515     3573      +58     
- Partials      913      914       +1     

Impacted Files	Coverage Δ
alpha/template/semver/semver.go	64.53% <33.33%> (ø)
pkg/sqlite/conversion.go	52.17% <33.33%> (-0.86%)	⬇️
alpha/template/composite/builder.go	58.04% <48.57%> (ø)
alpha/template/composite/composite.go	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[openshift-ci-robot]

@grokspawn: This pull request references OPECO-2664 which is a valid jira issue.

In response to this:

Description of the change:
Renaming all references from veneer to template. Catalog Template is now the accepted term, and this just enforces all code references to be consistent.

Along the way, we discovered that

• cobra command hierarchies will only exit with non-zero status if there is an unbroken chain of provided Run[E] functions from parent to child, so this includes some empty Run methods to preserve this chain
• the base image for opm to render fragments from composite template does not support the name-change, but we have to merge this PR to be able to release an image which will, so this includes temporary skips of utests which were failing due to the image dependency.

Motivation for the change:

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[oceanc80]

/lgtm