Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] bump containerd to 1.6.22 #1134

Merged

Conversation

grokspawn
Copy link
Contributor

Description of the change:
bump containerd from the patch-support-only 1.5.Z line to 1.6.22.

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1134 (fe9d1f0) into master (87c0b28) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1134      +/-   ##
==========================================
+ Coverage   53.79%   53.81%   +0.01%     
==========================================
  Files         108      108              
  Lines       10166    10166              
==========================================
+ Hits         5469     5471       +2     
+ Misses       3736     3734       -2     
  Partials      961      961              

see 1 file with indirect coverage changes

@grokspawn
Copy link
Contributor Author

grokspawn commented Aug 7, 2023

@oceanc80 @joelanford
1.6.Z of containerd supports token refresh. I'm probably missing some mechanism here, but when I force oc-mirror to use this bumped registry repo (via replaces in go.mod) -- even with no code changes to hook the token refresh handler -- I'm seeing the token refreshed in response to a 401 authorized status from the to-be-mirrored registry.

And the same test for oc-mirror results in a continuous stream of 401s which make it terminate.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oceanc80
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit dba1e10 into operator-framework:master Aug 15, 2023
13 checks passed
@grokspawn grokspawn deleted the containerd-bump branch August 16, 2023 17:19
@grokspawn
Copy link
Contributor Author

Fixes #1048

@grokspawn
Copy link
Contributor Author

Fixes #962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants