Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump sigs.k8s.io/controller-runtime from 0.16.3 to 0.17.2 #1227

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 16, 2024

Bumps sigs.k8s.io/controller-runtime from 0.16.3 to 0.17.2.

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.17.2

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.17.1...v0.17.2

v0.17.1

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.17.0...v0.17.1

v0.17.0

⚠️ Breaking Changes

  • Fake client: Only set TypeMeta for unstructured (#2633)
  • Update k8s.io/* deps to 1.29 (#2457 #2500 #2553 #2588 #2612 #2615 #2621)
  • Remove apiutil.NewDiscoveryRESTMapper, use DynamicRESTMapper by default for cache (#2611)
  • RESTMapper: don't treat non-existing GroupVersions as errors (#2571)
  • Webhooks: Deprecate admission.Validator and admission.Defaulter (#2639)
  • Webhooks: Limit size of AdmissionRequests to 7MB and size of TokenReviews to 1MB (#2598)

✨ New Features

  • Cache: Allow defining options that apply to all namespaces without explicit config (#2528)
  • Cache: Allow to remove informers (#2285)
  • Cache: Add option to set WatchErrorHandler on informers (#2494)
  • Client: client.MatchingFields now supports multiple indexes (#2512)
  • Fake client: Add flowcontrol api v1 (#2623)
  • Reconciler: Add reconcile.ObjectReconciler (#2592)

🐛 Bug Fixes

  • Add corev1, coordinationv1 scheme for leader election when LeaderElection manager option is true (#2461)
  • Cache: Default namespace only for namespaced object (#2480)
  • Client: Don't truncate large int64s in MergePatch (#2650)
  • controllerutil: Add RemoveControllerReference and HasControllerReference func (#2509 #2595)
  • controllerutil: Add RemoveOwnerReference func (#2462)
  • Dependencies: Refactor tests to drop hard otel dependency (#2460)
  • Envtest: CRDs that aren't convertible should unset spec.conversion (#2525)
  • Fake client: Correctly identify if patch call was made on status (#2508)
  • Fake client: Do not update anything but status when using subresource client (#2479)
  • Fake client: Fix returning object after status update (#2489)
  • Fake client: Fix status subresource getting updated on Update when it is empty (#2484)
  • Fake client: Handle unstructured status update with fake client (#2495)

... (truncated)

Commits
  • d0396a3 Merge pull request #2688 from k8s-infra-cherrypick-robot/cherry-pick-2687-to-...
  • 565aa5b Fix lazy rest mapper cache invalidation
  • 59c26c0 Merge pull request #2681 from k8s-infra-cherrypick-robot/cherry-pick-2679-to-...
  • 984aee6 bug: Fakeclient: Do not consider an apply patch to be a strategic merge patch
  • 5923139 Merge pull request #2676 from k8s-infra-cherrypick-robot/cherry-pick-2663-to-...
  • 0811bad Address review comments
  • 40b41df Clean restmapper cache if a version is notFound
  • 11e5a5e Merge pull request #2651 from kubernetes-sigs/dependabot/go_modules/github.co...
  • 66939d4 Merge pull request #2655 from joelanford/bump-apidiff
  • 672d678 bump go-apidiff to v0.8.2
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Feb 16, 2024
Copy link
Contributor

openshift-ci bot commented Feb 16, 2024

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.81%. Comparing base (71c6c7f) to head (49962d5).
Report is 2 commits behind head on master.

❗ Current head 49962d5 differs from pull request most recent head 8e75991. Consider uploading reports for the commit 8e75991 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
- Coverage   54.02%   53.81%   -0.22%     
==========================================
  Files         108      108              
  Lines       11266    10385     -881     
==========================================
- Hits         6087     5589     -498     
+ Misses       4190     3814     -376     
+ Partials      989      982       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn
Copy link
Contributor

/ok-to-test
/approve
/lgtm

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 15, 2024
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 15, 2024
@grokspawn grokspawn added this pull request to the merge queue Mar 15, 2024
@grokspawn grokspawn removed this pull request from the merge queue due to a manual request Mar 15, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/sigs.k8s.io/controller-runtime-0.17.2 branch from 49962d5 to a9fbccc Compare March 15, 2024 19:05
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 19, 2024
@perdasilva
Copy link
Contributor

@grokspawn I've tried to fix the conflicts through GH but it didn't work T_T this one also seems to bump some kube libs to 29.2 - not sure if we want to hold back on it or not...=S

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2024
@grokspawn
Copy link
Contributor

/hold on this to coordinate a k8s bump in api, o-r, and o-l-m quasi-simultaneously.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2024
@grokspawn
Copy link
Contributor

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 1, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@grokspawn
Copy link
Contributor

@dependabot recreate

Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.16.3 to 0.17.2.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.16.3...v0.17.2)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/sigs.k8s.io/controller-runtime-0.17.2 branch from feb236a to 8e75991 Compare April 1, 2024 19:09
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2024
@grokspawn
Copy link
Contributor

/hold cancel
bumping k8s in all v0 repos now

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 1, 2024
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b550209 into master Apr 1, 2024
14 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/sigs.k8s.io/controller-runtime-0.17.2 branch April 1, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies Pull requests that update a dependency file go Pull requests that update Go code lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants