pkg/cache: set explicit mode to handle upcoming go1.22 defaulting in fstest.MapFS #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fstest.MapFS Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
openshift-ci
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1279 +/- ##
==========================================
- Coverage 54.02% 54.02% -0.01%
==========================================
Files 108 108
Lines 11266 11266
==========================================
- Hits 6087 6086 -1
- Misses 4190 4191 +1
Partials 989 989 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
kevinrizza
approved these changes
Apr 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
via the queue into
operator-framework:master
with commit Apr 19, 2024
aa0777c
11 of 12 checks passed
renovate bot
added a commit
to registry-operator/registry-operator
that referenced
this pull request
Apr 26, 2024
…try to v1.40.0 (#36) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/operator-framework/operator-registry](https://github.com/operator-framework/operator-registry) | `v1.39.0` -> `v1.40.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>operator-framework/operator-registry (github.com/operator-framework/operator-registry)</summary> ### [`v1.40.0`](https://github.com/operator-framework/operator-registry/releases/tag/v1.40.0) [Compare Source](https://github.com/operator-framework/operator-registry/compare/v1.39.0...v1.40.0) #### What's Changed - build(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1250 - build(deps): bump sigs.k8s.io/kind from 0.20.0 to 0.22.0 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1249 - build(deps): bump github.com/containers/image/v5 from 5.29.0 to 5.30.0 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1253 - build(deps): bump github.com/containerd/containerd from 1.7.11 to 1.7.14 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1252 - build(deps): bump github.com/docker/cli from 25.0.5+incompatible to 26.0.0+incompatible by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1251 - build(deps): bump github.com/onsi/gomega from 1.31.1 to 1.32.0 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1254 - build(deps): bump github.com/joelanford/ignore from 0.0.0-20210607151042-0d25dc18b62d to 0.1.0 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1258 - build(deps): bump google.golang.org/grpc from 1.61.1 to 1.62.1 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1257 - build(deps): bump github.com/containers/common from 0.57.1 to 0.58.1 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1256 - build(deps): bump github.com/grpc-ecosystem/grpc-health-probe from 0.4.24 to 0.4.25 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1255 - build(deps): bump google.golang.org/grpc from 1.62.1 to 1.63.0 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1260 - build(deps): bump golang.org/x/mod from 0.16.0 to 0.17.0 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1261 - build(deps): bump golang.org/x/sys from 0.18.0 to 0.19.0 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1262 - build(deps): bump golang.org/x/net from 0.22.0 to 0.24.0 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1263 - build(deps): bump golang.org/x/sync from 0.6.0 to 0.7.0 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1264 - build(deps): bump sigs.k8s.io/controller-runtime from 0.17.2 to 0.17.3 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1266 - build(deps): bump google.golang.org/grpc from 1.63.0 to 1.63.2 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1267 - build(deps): bump github.com/containerd/containerd from 1.7.14 to 1.7.15 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1265 - build(deps): bump github.com/docker/cli from 26.0.0+incompatible to 26.0.1+incompatible by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1268 - build(deps): bump github.com/containers/common from 0.58.1 to 0.58.2 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1269 - pkg/cache: set explicit mode to handle upcoming go1.22 defaulting in fstest.MapFS by [@​joelanford](https://github.com/joelanford) in [operator-framework/operator-registry#1279 - build(deps): bump github.com/onsi/gomega from 1.32.0 to 1.33.0 by [@​dependabot](https://github.com/dependabot) in [operator-framework/operator-registry#1280 - providing a constraint property constant for dependency consistency by [@​grokspawn](https://github.com/grokspawn) in [operator-framework/operator-registry#1282 **Full Changelog**: operator-framework/operator-registry@v1.39.0...v1.40.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/registry-operator/registry-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhcmVhL2RlcGVuZGVuY3kiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Add a directory entry for "." in the
validFSwith permissions explicitly zero'd.Motivation for the change:
This is a pre-emptive change that we should make prior to bumping
opmto go1.22, because in go1.22fstest.MapFSnow sets0555permissions on synthesized directories.This aligns with the existing assumptions and ensures that our expected digest remains stable.
Reviewer Checklist
/docs