Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bingo for managing tool deps #1329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented May 29, 2024

Description of the change:

  • Use bingo for tool management
  • Require a specific version of protoc (and include a helper that downloads it)

Motivation for the change:

  • Drive developer and CI consistency
  • Also note that protoc is not a go binary, so it requires a separate helper script to download it and check its version.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.02%. Comparing base (da4828d) to head (6d9fa50).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1329   +/-   ##
=======================================
  Coverage   50.02%   50.02%           
=======================================
  Files         135      135           
  Lines       13006    13006           
=======================================
  Hits         6506     6506           
  Misses       5416     5416           
  Partials     1084     1084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford changed the title add bingo for managing tool deps (except protobuf tools) add bingo for managing tool deps May 29, 2024
Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [grokspawn,joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants