-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to kube 1.16 #87
Bump to kube 1.16 #87
Conversation
// GetVersion returns the version of the CSV | ||
// | ||
// If not defined, the function returns an empty string. | ||
func (csv *ClusterServiceVersion) GetVersion() (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only non-dependency change
I'm curious how to properly solve this: vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/lib/operatorclient/serviceaccount.go:38:2: not enough arguments to return The first OLM release to not use c.Core is 4.2. Perhaps the rule should be to vendor the latest OLM that contains the most recent rebase? |
this is used in OLM to handle csvs from a catalog without parsing them fully (and abstract over changes in underlying types)
this is not used in operator-registry anymore, and will be replaced by the validation library
@ecordell I assume you remove the schema because we have a validation library now and will vendor that library at a later time? |
@dinhxuanvu Yep! I mentioned that in the commit message as well. |
/hold Just noticed the version of olm being vendored is wrong. |
/hold cancel operator-registry no longer depends on OLM at all 🙃 |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of the change:
This bumps the kube libraries to the versions used in kube 1.16.
It also adds one supporting method to the bundle
csv
abstraction so that OLM can get the version data without fully parsing the csv from the bundle.Reviewer Checklist
/docs