Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to kube 1.16 #87

Merged
merged 4 commits into from
Sep 25, 2019

Conversation

ecordell
Copy link
Member

Description of the change:

This bumps the kube libraries to the versions used in kube 1.16.

It also adds one supporting method to the bundle csv abstraction so that OLM can get the version data without fully parsing the csv from the bundle.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 25, 2019
// GetVersion returns the version of the CSV
//
// If not defined, the function returns an empty string.
func (csv *ClusterServiceVersion) GetVersion() (string, error) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only non-dependency change

@jpeeler
Copy link

jpeeler commented Sep 25, 2019

I'm curious how to properly solve this:

vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/lib/operatorclient/serviceaccount.go:38:2: not enough arguments to return
vendor/github.com/operator-framework/operator-lifecycle-manager/pkg/lib/operatorclient/serviceaccount.go:38:10: c.Core undefined (type *Client has no field or method Core)

The first OLM release to not use c.Core is 4.2. Perhaps the rule should be to vendor the latest OLM that contains the most recent rebase?

this is used in OLM to handle csvs from a catalog without parsing
them fully (and abstract over changes in underlying types)
this is not used in operator-registry anymore, and will be replaced
by the validation library
@dinhxuanvu
Copy link
Member

@ecordell I assume you remove the schema because we have a validation library now and will vendor that library at a later time?

@ecordell
Copy link
Member Author

@dinhxuanvu Yep! I mentioned that in the commit message as well.

@ecordell
Copy link
Member Author

/hold

Just noticed the version of olm being vendored is wrong.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2019
@ecordell
Copy link
Member Author

/hold cancel

operator-registry no longer depends on OLM at all 🙃

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2019
@jpeeler
Copy link

jpeeler commented Sep 25, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2019
@jpeeler
Copy link

jpeeler commented Sep 25, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, jpeeler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2f3ee84 into operator-framework:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants