Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump grpc probe to version 0.4.11 #967

Merged

Conversation

perdasilva
Copy link
Contributor

Signed-off-by: perdasilva perdasilva@redhat.com

Description of the change:
Clean up twistlock scan issues identified in #959

Motivation for the change:
#959 and https://bugzilla.redhat.com/show_bug.cgi?id=2083919

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #967 (0be7dd3) into master (1436816) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #967   +/-   ##
=======================================
  Coverage   52.48%   52.48%           
=======================================
  Files         103      103           
  Lines        9240     9240           
=======================================
  Hits         4850     4850           
  Misses       3468     3468           
  Partials      922      922           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1436816...0be7dd3. Read the comment docs.

@tylerslaton
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2022
@joelanford
Copy link
Member

The main Dockerfile that needs to be fixed is: https://github.com/operator-framework/operator-registry/blob/master/release/goreleaser.opm.Dockerfile

That's the one that builds quay.io/operator-framework/opm. I'm not sure we even use the other ones anymore. Maybe downstream does? Not sure.

Signed-off-by: perdasilva <perdasilva@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2022

New changes are detected. LGTM label has been removed.

@perdasilva perdasilva added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit cefb2f6 into operator-framework:master May 30, 2022
@eveliososa
Copy link

@perdasilva are there any plans to update the grcp probe version again to the latest version? There are critical CVEs in the 4.11 version of grpc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants