This repository has been archived by the owner on Nov 18, 2020. It is now read-only.
upgrade go sample to new layout #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilamacedo86
requested review from
estroz,
bharathi-tenneti,
jmrodri and
varshaprasad96
and removed request for
estroz and
bharathi-tenneti
|
/hold I upgrade the sample with master and our latest tag release here is v0.18.1. c/c @joelanford |
openshift-ci-robot
added
the
do-not-merge/hold
ravitri
reviewed
Jul 28, 2020
| @@ -0,0 +1,63 @@ | |||
| apiVersion: apiextensions.k8s.io/v1beta1 | |||
There was a problem hiding this comment.
@camilamacedo86 - As per operator-framework/operator-lifecycle-manager#1416, the CRD defaults to v1 version than v1beta1 and k8s 1.19 will deprecate v1beta1 for CRD as such.. What about defaulting to v1 version of CRD in new layout?
There was a problem hiding this comment.
Tks for raise your concern see: operator-framework/operator-sdk#3580
|
Hi @varshaprasad96, I will close this one because was made manually and you are working on it the script. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PS.: The steps to test are in the README which was updated in this PR.