Skip to content

Commit

Permalink
interanl/util/projutil/proj_util.go: docker build command DockerBuild()
Browse files Browse the repository at this point in the history
  • Loading branch information
estroz committed Nov 30, 2018
1 parent cc1fb60 commit 5f252b2
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 11 deletions.
16 changes: 5 additions & 11 deletions commands/operator-sdk/cmd/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,7 @@ func buildFunc(cmd *cobra.Command, args []string) {
log.Fatalf("failed to build operator binary: (%v)", err)
}
}
buildCmd := exec.Command("docker", "build", ".",
"-f", buildDockerfile,
"-t", baseImageName)
err := projutil.ExecCmd(buildCmd)
err := projutil.DockerBuild(buildDockerfile, baseImageName)
if err != nil {
if enableTests {
log.Fatalf("failed to output intermediate image %s: (%v)", image, err)
Expand Down Expand Up @@ -207,13 +204,10 @@ func buildFunc(cmd *cobra.Command, args []string) {
log.Fatalf("failed to build operator binary: (%v)", err)
}
}
testBuildCmd := exec.Command("docker", "build", ".",
"-f", testDockerfile,
"-t", image,
"--build-arg", "TESTDIR="+testLocationBuild,
"--build-arg", "BASEIMAGE="+baseImageName,
"--build-arg", "NAMESPACEDMAN="+namespacedManBuild)
err = projutil.ExecCmd(testBuildCmd)
err = projutil.DockerBuild(testDockerfile, image,
"TESTDIR="+testLocationBuild,
"BASEIMAGE="+baseImageName,
"NAMESPACEDMAN="+namespacedManBuild)
if err != nil {
log.Fatalf("failed to output test image %s: (%v)", image, err)
}
Expand Down
13 changes: 13 additions & 0 deletions internal/util/projutil/project_util.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,3 +174,16 @@ func ExecCmd(cmd *exec.Cmd) error {
}
return nil
}

func DockerBuild(dockerfile, image string, buildArgs ...string) error {
args := []string{"build", ".", "-f", dockerfile, "-t", image}
for _, arg := range buildArgs {
args = append(args, "--build-arg", arg)
}
bcmd := exec.Command("docker", args...)
err := ExecCmd(bcmd)
if err != nil {
return fmt.Errorf("error building docker image %s: %v", image, err)
}
return nil
}

0 comments on commit 5f252b2

Please sign in to comment.