controller-runtime currently adds the --kubeconfig flag if

pkg/client/config is imported (set up in an init() function).
The SDK's test framework also adds this flag, which will panic
if both are imported and the test framework is initialized.
This commit creates a new flag.FlagSet for the test framework
instead of using the global one.

pkg/test: use local flag.FlagSet instead of flag.CommandLine

pkg/test/framework.go

@@ -99,10 +99,10 @@ const (
 
 func (opts *frameworkOpts) addToFlagSet(flagset *flag.FlagSet) {
 	flagset.StringVar(&opts.projectRoot, ProjRootFlag, "", "path to project root")
+	flagset.StringVar(&opts.kubeconfigPath, KubeConfigFlag, "", "path to kubeconfig")
 	flagset.StringVar(&opts.namespacedManPath, NamespacedManPathFlag, "", "path to rbac manifest")
 	flagset.BoolVar(&opts.isLocalOperator, LocalOperatorFlag, false,
 		"enable if operator is running locally (not in cluster)")
-	flagset.StringVar(&opts.kubeconfigPath, KubeConfigFlag, "", "path to kubeconfig")
 	flagset.StringVar(&opts.globalManPath, GlobalManPathFlag, "", "path to operator manifest")
 	flagset.StringVar(&opts.localOperatorArgs, LocalOperatorArgs, "",
 		"flags that the operator needs (while using --up-local). example: \"--flag1 value1 --flag2=value2\"")

pkg/test/main_entry.go

@@ -24,8 +24,10 @@ import (
 
 func MainEntry(m *testing.M) {
 	fopts := &frameworkOpts{}
-	fopts.addToFlagSet(flag.CommandLine)
-	flag.Parse()
+	fs := flag.NewFlagSet(os.Args[0], flag.ExitOnError)
+	fopts.addToFlagSet(fs)
+
+	fs.Parse(os.Args[1:])
 
 	f, err := newFramework(fopts)
 	if err != nil {