0.11.0 - operator-sdk test fails due to redefined flags #2167

patelajayp · 2019-11-06T22:08:10Z

Bug Report

What did you do?
Ran operator-sdk test local ./test/e2e/ --no-setup --namespace sdktest to test operator locally

What did you expect to see?
Tests to run and pass

What did you see instead? Under which circumstances?
Failed with the following error:

INFO[0000] Testing operator locally.                    
/var/folders/80/9gfhhzsj62x3xt6gm81hpz6n015xt2/T/go-build638281781/b001/e2e.test flag redefined: kubeconfig
panic: /var/folders/80/9gfhhzsj62x3xt6gm81hpz6n015xt2/T/go-build638281781/b001/e2e.test flag redefined: kubeconfig

goroutine 1 [running]:
flag.(*FlagSet).Var(0xc0000ce0c0, 0x2591da0, 0xc000416b30, 0x2360c39, 0xa, 0x23799e8, 0x12)
	/usr/local/Cellar/go/1.13.1/libexec/src/flag/flag.go:848 +0x4ae
flag.(*FlagSet).StringVar(...)
	/usr/local/Cellar/go/1.13.1/libexec/src/flag/flag.go:751
flag.(*FlagSet).String(0xc0000ce0c0, 0x2360c39, 0xa, 0x0, 0x0, 0x23799e8, 0x12, 0xc000416b20)
	/usr/local/Cellar/go/1.13.1/libexec/src/flag/flag.go:764 +0xa0
flag.String(...)
	/usr/local/Cellar/go/1.13.1/libexec/src/flag/flag.go:771
github.com/operator-framework/operator-sdk/pkg/test.MainEntry(0xc00051e480)
	/Users/user/go/pkg/mod/github.com/operator-framework/operator-sdk@v0.11.0/pkg/test/main_entry.go:51 +0xc4
gitlab.com/repository/test/e2e.TestMain(...)
	/path/to/project/test/e2e/main_test.go:10
main.main()
	_testmain.go:42 +0x136
FAIL	gitlab.com/repository/test/e2e	0.047s
FAIL
Error: failed to build test binary: (failed to exec []string{"go", "test", "./test/e2e//...", "-namespacedMan", "deploy/test/empty.yaml", "-globalMan", "deploy/test/empty.yaml", "-root", "/Users/user/project", "-singleNamespace", "-parallel=1"}: exit status 1)

Environment

operator-sdk version: "v0.11.0", commit: "39c65c36159a9c249e5f3c178205cc6e86c16f8d", go version: "go1.12.7 darwin/amd64"

go version: go version go1.13.1 darwin/amd64

Kubernetes version information:
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.2", GitCommit:"f6278300bebbb750328ac16ee6dd3aa7d3549568", GitTreeState:"clean", BuildDate:"2019-08-05T16:54:35Z", GoVersion:"go1.12.7", Compiler:"gc", Platform:"darwin/amd64"} Server Version: version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.11-eks-5876d6", GitCommit:"5876d6b7429820450950ade17fe7b4bf5ccada7f", GitTreeState:"clean", BuildDate:"2019-09-24T20:54:25Z", GoVersion:"go1.11.13", Compiler:"gc", Platform:"linux/amd64"}

Are you writing your operator in ansible, helm, or go?
Go

The text was updated successfully, but these errors were encountered:

camilamacedo86 · 2019-11-06T23:15:11Z

Hi @patelajayp,

Note that the v0.11.0 is not supporting the go version 1.13+. Could you try to use the latest release of the SDK(0.12) and let us know if you still facing any issue with?

patelajayp · 2019-11-07T15:03:31Z

I upgraded my operator-sdk version to:

"v0.12.0", commit: "2445fcda834ca4b7cf0d6c38fba6317fb219b469", go version: "go1.13.3 darwin/amd64"

and am still having the same issue.

camilamacedo86 · 2019-11-07T15:42:34Z

Hi @patelajayp,

Following some tips that I hope that help you to solve it.

Use ./test/e2e instead of ./test/e2e/. See the error "./test/e2e//..."
Use --namespace=${NAMESPACE} intead of --namespace X
Ensure that the k8s cluster is up and running
Ensure that all is applied in the cluster since you are using --no-setup

If you still facing the issue try to use --debug and --verbose to get further information and add the error here.

@AlexNPavel you have more knowledge over the test-framework. Could you give a hand here?

robbie-demuth · 2019-11-11T20:28:04Z

@camilamacedo86 - As Ajay mentioned, we've updated our project to 0.12.0 and are still hitting the same issue. It looks like two dependencies are declaring the same flag, but I'm unsure how to tell which ones they both are. We've also validated and/or tried all of your tips. Here's the output with --debug and --verbose

$ operator-sdk test local ./test/e2e --go-test-flags "-timeout=0" --no-setup --namespace operator-sdk-0-12-0 --debug --verbose
DEBU[0000] Debug logging is set
INFO[0000] Testing operator locally.
DEBU[0000] Running []string{"go", "test", "./test/e2e/...", "-namespacedMan", "deploy/test/empty.yaml", "-globalMan", "deploy/test/empty.yaml", "-root", "/Users/robbie.demuth/repo/my-operator", "-timeout=0", "-singleNamespace", "-parallel=1"}
/var/folders/j5/774djqhj6v9_6v_s5g3_v0zw4mwwjp/T/go-build074198978/b001/e2e.test flag redefined: kubeconfig
panic: /var/folders/j5/774djqhj6v9_6v_s5g3_v0zw4mwwjp/T/go-build074198978/b001/e2e.test flag redefined: kubeconfig

goroutine 1 [running]:
flag.(*FlagSet).Var(0xc0000ec060, 0x24b7180, 0xc00015d970, 0x2297ac7, 0xa, 0x22af22d, 0x12)
	/usr/local/Cellar/go/1.13.1/libexec/src/flag/flag.go:848 +0x4ae
flag.(*FlagSet).StringVar(...)
	/usr/local/Cellar/go/1.13.1/libexec/src/flag/flag.go:751
flag.(*FlagSet).String(0xc0000ec060, 0x2297ac7, 0xa, 0x0, 0x0, 0x22af22d, 0x12, 0xc00015d960)
	/usr/local/Cellar/go/1.13.1/libexec/src/flag/flag.go:764 +0xa0
flag.String(...)
	/usr/local/Cellar/go/1.13.1/libexec/src/flag/flag.go:771
github.com/operator-framework/operator-sdk/pkg/test.MainEntry(0xc00061b880)
	/Users/robbie.demuth/go/pkg/mod/github.com/operator-framework/operator-sdk@v0.12.0/pkg/test/main_entry.go:51 +0xc4
gitlab.com/my-operator/test/e2e.TestMain(...)
	/Users/robbie.demuth/repo/my-operator/test/e2e/main_test.go:10
main.main()
	_testmain.go:42 +0x136
FAIL	gitlab.com/my-operator/test/e2e	0.042s
FAIL
Error: failed to build test binary: (failed to exec []string{"go", "test", "./test/e2e/...", "-namespacedMan", "deploy/test/empty.yaml", "-globalMan", "deploy/test/empty.yaml", "-root", "/Users/robbie.demuth/repo/my-operator", "-timeout=0", "-singleNamespace", "-parallel=1"}: exit status 1)
Usage:
  operator-sdk test local <path to tests directory> [flags]

Flags:
      --debug                         Enable debug-level logging
      --global-manifest string        Path to manifest for Global resources (e.g. CRD manifests)
      --go-test-flags string          Additional flags to pass to go test
  -h, --help                          help for local
      --image string                  Use a different operator image from the one specified in the namespaced manifest
      --kubeconfig string             Kubeconfig path
      --local-operator-flags string   The flags that the operator needs (while using --up-local). Example: "--flag1 value1 --flag2=value2"
      --molecule-test-flags string    Additional flags to pass to molecule test
      --namespace string              If non-empty, single namespace to run tests in
      --namespaced-manifest string    Path to manifest for per-test, namespaced resources (e.g. RBAC and Operator manifest)
      --no-setup                      Disable test resource creation
      --up-local                      Enable running operator locally with go run instead of as an image in the cluster

Global Flags:
      --verbose   Enable verbose logging

robbie-demuth · 2019-11-11T20:47:53Z

@camilamacedo86 - So I did a bit more digging and was finally able to debug the end-to-end tests in Goland. It looks like there's a package in controller-runtime that defines the kubeconfig flag in its init function, which conflicts with the similarly named flag in the Operator SDK

controller-runtime
https://github.com/kubernetes-sigs/controller-runtime/blob/v0.3.0/pkg/client/config/config.go#L38-L40

operator-sdk
https://github.com/operator-framework/operator-sdk/blob/v0.12.0/pkg/test/main_entry.go#L51

I'd imagine that this must be causing a problem for all 0.12.0 projects since they use controller-runtime v0.3.0, no? For what it's worth, the flag is also in controller-runtime 0.2.0 as well

joelanford · 2019-11-11T22:00:26Z

Hmm. We have e2e tests in our CI system that run the e2e framework and those tests are still passing. So something funky is going on here. Thanks for raising this issue! I'll dig into this.

openshift-bot · 2020-02-10T01:11:12Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

thebithead · 2020-02-20T21:07:24Z

/remove-lifecycle stale

thebithead · 2020-02-20T21:10:56Z

I have run into this as well.

tgates@tgu19:~/gopath/src/github.com/nuodb/nuodb-operator$ operator-sdk test local ./ntest/e2e --namespace $OPERATOR_NAMESPACE --verbose --kubeconfig ~/.kube/config --image $NUODB_OP_IMAGE --debug --verbose
DEBU[0000] Debug logging is set                         
INFO[0000] Testing operator locally.                    
DEBU[0000] Running []string{"go", "test", "./ntest/e2e/...", "-namespacedMan", "/tmp/namespaced-manifest.yaml320222523", "-globalMan", "/tmp/global-manifest.yaml917165918", "-root", "/home/tgates/gopath/src/github.com/nuodb/nuodb-operator", "-kubeconfig", "/home/tgates/.kube/config", "-singleNamespace", "-parallel=1"} 
/tmp/go-build637475276/b001/e2e.test flag redefined: kubeconfig
panic: /tmp/go-build637475276/b001/e2e.test flag redefined: kubeconfig

goroutine 1 [running]:
flag.(*FlagSet).Var(0xc0000521e0, 0x1cc2ba0, 0xc0002f5f00, 0x1a65c0a, 0xa, 0x1a7e830, 0x12)
	/usr/local/go/src/flag/flag.go:848 +0x4ae
flag.(*FlagSet).StringVar(...)
	/usr/local/go/src/flag/flag.go:751
flag.(*FlagSet).String(0xc0000521e0, 0x1a65c0a, 0xa, 0x0, 0x0, 0x1a7e830, 0x12, 0xc0002f5ed0)
	/usr/local/go/src/flag/flag.go:764 +0xa0
flag.String(...)
	/usr/local/go/src/flag/flag.go:771
github.com/operator-framework/operator-sdk/pkg/test.MainEntry(0xc000671d00)
	/home/tgates/gopath/pkg/mod/github.com/operator-framework/operator-sdk@v0.9.0/pkg/test/main_entry.go:51 +0xc4
nuodb/nuodb-operator/ntest/e2e.TestMain(...)
	/home/tgates/gopath/src/github.com/nuodb/nuodb-operator/ntest/e2e/main_test.go:10
main.main()
	_testmain.go:50 +0x136
FAIL	nuodb/nuodb-operator/ntest/e2e	0.029s
?   	nuodb/nuodb-operator/ntest/e2e/util	[no test files]
FAIL
Error: failed to build test binary: (failed to exec []string{"go", "test", "./ntest/e2e/...", "-namespacedMan", "/tmp/namespaced-manifest.yaml320222523", "-globalMan", "/tmp/global-manifest.yaml917165918", "-root", "/home/tgates/gopath/src/github.com/nuodb/nuodb-operator", "-kubeconfig", "/home/tgates/.kube/config", "-singleNamespace", "-parallel=1"}: exit status 1)
Usage:
  operator-sdk test local <path to tests directory> [flags]

Flags:
      --debug                         Enable debug-level logging
      --global-manifest string        Path to manifest for Global resources (e.g. CRD manifests)
      --go-test-flags string          Additional flags to pass to go test
  -h, --help                          help for local
      --image string                  Use a different operator image from the one specified in the namespaced manifest
      --kubeconfig string             Kubeconfig path
      --local-operator-flags string   The flags that the operator needs (while using --up-local). Example: "--flag1 value1 --flag2=value2"
      --molecule-test-flags string    Additional flags to pass to molecule test
      --namespace string              If non-empty, single namespace to run tests in
      --namespaced-manifest string    Path to manifest for per-test, namespaced resources (e.g. RBAC and Operator manifest)
      --no-setup                      Disable test resource creation
      --up-local                      Enable running operator locally with go run instead of as an image in the cluster

Global Flags:
      --verbose   Enable verbose logging

Environment

operator-sdk version: "operator-sdk version: v0.9.0, commit: 560208d"

go version: "go version go1.13.5 linux/amd64"

Kubernetes version information:"Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-08T17:11:31Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}"
"Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.6+32dc4a0", GitCommit:"32dc4a0", GitTreeState:"clean", BuildDate:"2019-12-10T07:52:29Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}"

Are you writing your operator in ansible, helm, or go?
Go

camilamacedo86 · 2020-02-21T03:21:35Z

Hi @thebithead,

Note that the version 0.9.0 is not compatible with the Go 1.13+. Could you please check it with the latest version of SDK.

asmacdo · 2020-03-09T18:51:24Z

If this is still an issue, please reopen.

camilamacedo86 · 2020-03-09T19:04:05Z

Hi @thebithead,

Just to let you know we discussed it in the bug triaged and we decide to close since shows that the same will no be faced if you are using the 1.13+ go version and the latest version of SDK. However, if you still facing this issue please let us know for we are able to re-open this one and please provide the data regards your latest test/check as well.

thebithead · 2020-03-09T19:57:26Z

I was able to replicate the problem using Go version 1.12. But I wanted to go forward, not backwards.

…

On Mon, Mar 9, 2020 at 3:04 PM Camila Macedo ***@***.***> wrote: Hi @thebithead <https://github.com/thebithead>, Just to let you know we discussed it in the bug triaged and we decide to close since shows that the same will no be faced if you are using the 1.13+ go version and the latest version of SDK. However, if you still facing this issue please let us know for we are able to re-open this one and please provide the data regards your latest test/check as well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2167?email_source=notifications&email_token=AAKUNZYGHYVPLIRNRKE3DHTRGU4SNA5CNFSM4JJ6MO7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOIU33Q#issuecomment-596725230>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKUNZ3LWSX3XZQ23K42LN3RGU4SNANCNFSM4JJ6MO7A> .

-- *Tom Gates* Software Engineer *www.nuodb.com* <http://www.nuodb.com/> c: (603) 865-7134 t: @nuodb <https://twitter.com/nuodb> f: *facebook.com/NUODB <https://www.facebook.com/NUODB>* The information contained in this email is confidential and proprietary and intended for the sole use of the intended recipient. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this email in error, please notify the sender and delete all copies.

camilamacedo86 · 2020-03-09T20:10:48Z

Hi @thebithead the Go version 1.12. is not supportable with the latest version. Then, issue can really occur with if you are using Go version 1.12. So, I understand that all is fine when you are using the go 1.13+ and the latest, Am I right?

thebithead · 2020-03-09T21:17:11Z

No. I was able to replicate the problem using SDK version 0.9.0 and Go version 1.12. I did not (yet) try using the latest SDK version.

…

On Mon, Mar 9, 2020 at 4:10 PM Camila Macedo ***@***.***> wrote: Hi @thebithead <https://github.com/thebithead> the Go version 1.12. is not supportable with the latest version. Then, issue can really occur with if you are using Go version 1.12. So, I understand that all is fine when you are using the go 1.13+ and the latest, Am I right? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2167?email_source=notifications&email_token=AAKUNZ67BVNIOPXPZSXGD3TRGVEMRA5CNFSM4JJ6MO7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOI4FQY#issuecomment-596755139>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKUNZYONDPLHTPMGONJ34TRGVEMRANCNFSM4JJ6MO7A> .

-- *Tom Gates* Software Engineer *www.nuodb.com* <http://www.nuodb.com/> c: (603) 865-7134 t: @nuodb <https://twitter.com/nuodb> f: *facebook.com/NUODB <https://www.facebook.com/NUODB>* The information contained in this email is confidential and proprietary and intended for the sole use of the intended recipient. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this email in error, please notify the sender and delete all copies.

robbie-demuth · 2020-04-16T12:47:00Z

FWIW, I think this is now solved by #2731

camilamacedo86 added triage/support Indicates an issue that is a support question. test-framework triage/needs-information Indicates an issue needs more information in order to work on it. and removed triage/support Indicates an issue that is a support question. labels Nov 6, 2019

joelanford self-assigned this Nov 11, 2019

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 10, 2020

openshift-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 20, 2020

asmacdo closed this as completed Mar 9, 2020

KevFan mentioned this issue Mar 25, 2020

INTLY-5764 - add test for subscription install plan type integr8ly/integreatly-operator#519

Merged

2 tasks

KevFan mentioned this issue May 21, 2020

test to verify 3Scale user promotion does not revert integr8ly/integreatly-operator#717

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

0.11.0 - operator-sdk test fails due to redefined flags #2167

0.11.0 - operator-sdk test fails due to redefined flags #2167

patelajayp commented Nov 6, 2019

camilamacedo86 commented Nov 6, 2019

patelajayp commented Nov 7, 2019

camilamacedo86 commented Nov 7, 2019

robbie-demuth commented Nov 11, 2019

robbie-demuth commented Nov 11, 2019 •

edited

Loading

joelanford commented Nov 11, 2019

openshift-bot commented Feb 10, 2020

thebithead commented Feb 20, 2020

thebithead commented Feb 20, 2020 •

edited

Loading

camilamacedo86 commented Feb 21, 2020

asmacdo commented Mar 9, 2020

camilamacedo86 commented Mar 9, 2020

thebithead commented Mar 9, 2020 via email

camilamacedo86 commented Mar 9, 2020

thebithead commented Mar 9, 2020 via email

robbie-demuth commented Apr 16, 2020

0.11.0 - operator-sdk test fails due to redefined flags #2167

0.11.0 - operator-sdk test fails due to redefined flags #2167

Comments

patelajayp commented Nov 6, 2019

Bug Report

camilamacedo86 commented Nov 6, 2019

patelajayp commented Nov 7, 2019

camilamacedo86 commented Nov 7, 2019

robbie-demuth commented Nov 11, 2019

robbie-demuth commented Nov 11, 2019 • edited Loading

joelanford commented Nov 11, 2019

openshift-bot commented Feb 10, 2020

thebithead commented Feb 20, 2020

thebithead commented Feb 20, 2020 • edited Loading

camilamacedo86 commented Feb 21, 2020

asmacdo commented Mar 9, 2020

camilamacedo86 commented Mar 9, 2020

thebithead commented Mar 9, 2020 via email

camilamacedo86 commented Mar 9, 2020

thebithead commented Mar 9, 2020 via email

robbie-demuth commented Apr 16, 2020

robbie-demuth commented Nov 11, 2019 •

edited

Loading

thebithead commented Feb 20, 2020 •

edited

Loading