Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Watch should keep retrying on failure and not panic #224

Closed
hasbro17 opened this issue May 3, 2018 · 2 comments
Closed

The Watch should keep retrying on failure and not panic #224

hasbro17 opened this issue May 3, 2018 · 2 comments
Assignees

Comments

@hasbro17
Copy link
Contributor

hasbro17 commented May 3, 2018

Currently if an operator tries to watch a Custom Resource type before the CRD is registered then it will panic because it can't create a resource client for an unregistered type.
https://github.com/operator-framework/operator-sdk/blob/https://github.com/operator-framework/operator-sdk/blob/0b429fb2ef27dd66d19e0028eb33fdfb445ad859/pkg/sdk/api.go#L44-L49/pkg/sdk/api.go#L44-L49

The operator pod will keep crashing and restarting until the CRD is created.

Ideally the Watch should keep retrying when it fails to create a resource client for an unknown type. This way the operator does not crash and will wait until the CRD is created.

This allows us to keep to keep the deployment and CRD manifests separate as well.
ref: #76

@hasbro17 hasbro17 self-assigned this May 3, 2018
@fanminshi
Copy link
Contributor

duplicate with #183?

@hasbro17
Copy link
Contributor Author

hasbro17 commented May 3, 2018

Closing in favor of #183

@hasbro17 hasbro17 closed this as completed May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants