-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep deployment and CRD manifests separate #76
Comments
@hasbro17 I think the original idea make user's life easier by combining both manifests into one. However, you observation makes sense. We can have 2 manifests like you have suggested and probably just run |
Can someone pls explain how is the deployment and the CRD linked? I dont see any names/groups/etc from CRDs mentioned in the deployment file. How are they connected?? |
…t with ART Combining PRs operator-framework#76, operator-framework#77, operator-framework#80, operator-framework#81, operator-framework#83 since they are based on really old branches with failing tests.
Currently we generate a single file
deploy/operator.yaml
that has the CRD and deployment manifests:The CRD is something that the user will only create once, but the operator Deployment is something the user might want to delete, edit and recreate multiple times.
For instance on my first run I forgot to specify the pull secret in the deployment manifest and had to edit the manifest and recreate it.
From a usability perspective it would be better to keep them as two separate files
deploy/operator.yaml
anddeploy/<kind>-CRD.yaml
and just specify in the README that the user should do the following:/cc @fanminshi @hongchaodeng
The text was updated successfully, but these errors were encountered: