-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discuss the behavior of operator-sdk new #83
Comments
It depends.
IMHO, this is not enough to determine if the output is what we want to generate. |
@hongchaodeng Can you explain your concern a bit more. I was thinking that the expected behavior from
|
I think the solution @hasbro17 mentioned above is good enough.
Not really a concern. As mentioned above, in order to skip some files and generate the rest, it needs both the input and output to be deterministic. Just checking the folder exists not enough. |
Sounds good. @fanminshi We'll proceed with the above mentioned behavior for now. |
yep! |
fixed via #85 |
…t with ART Combining PRs operator-framework#76, operator-framework#77, operator-framework#80, operator-framework#81, operator-framework#83 since they are based on really old branches with failing tests.
Current run
operator-sdk new app-operator --api-version=app.example.com/v1alpha1 --kind=AppService
creates a new folder calledapp-operator
. If I calloperator-sdk new app-operator --api-version=app.example.com/v1alpha1 --kind=AppService
, the command overrides everything there is in theapp-operator
folder. I don't think that's behavior we want. Inrails
, thenew
command skips any files that have been created and generates the ones that aren't there. The rails behavior seems great but might complicate the current operator-sdk new code base to support that. I think the simpler way is to check ifapp-operator
folder has been created already; if not, create it; if created, then skip the files and dirs creation.cc/ @hasbro17 @hongchaodeng
The text was updated successfully, but these errors were encountered: