commands/operator-sdk: check existing project #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manual Testing: |
|
cc/ @hasbro17 |
hasbro17
reviewed
Mar 2, 2018
commands/operator-sdk/cmd/new.go
Outdated
| @@ -75,6 +76,22 @@ func parse(args []string) { | |||
| } | |||
| } | |||
|
|
|||
| // existingProject checks if the given project exists under the current diretory. | |||
| // it exits with error when the project exists. | |||
| func existingProject() { | |||
There was a problem hiding this comment.
Just a suggestion, what about renaming it to mustBeNewProject() since that's the action the function is taking. But either way is fine.
There was a problem hiding this comment.
yeah, the suggested naming sounds better. i'll change to that.
|
LGTM |
m1kola
pushed a commit
to m1kola/operator-sdk
that referenced
this pull request
Jun 7, 2024
…-openshift-4.7 Updating o-e-(ansible|helm|sdk) builder & base images to be consistent with ART
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr allows operator-sdk new to first check if the current directory has the operator project already. if it exists, then output an error.
ref: #83