Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands/operator-sdk: pull deps after code generation #81

Merged
merged 2 commits into from
Mar 1, 2018
Merged

commands/operator-sdk: pull deps after code generation #81

merged 2 commits into from
Mar 1, 2018

Conversation

fanminshi
Copy link
Contributor

this pr allows operator-sdk new command to create vendor/ after code/scripts generation. this ensure the default generated files can be compiled.

@fanminshi
Copy link
Contributor Author

Manual Test:

$ operator-sdk new app-operator --api-version=app.example.com/v1alpha1 --kind=AppService
$ cd app-operator
$ ls
Gopkg.lock	cmd		deploy		tmp
Gopkg.toml	config		pkg		vendor

@fanminshi
Copy link
Contributor Author

cc/ @hasbro17

@hasbro17
Copy link
Contributor

hasbro17 commented Mar 1, 2018

LGTM

@fanminshi fanminshi merged commit e0c327e into operator-framework:master Mar 1, 2018
@fanminshi fanminshi mentioned this pull request Mar 1, 2018
21 tasks
m1kola pushed a commit to m1kola/operator-sdk that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants