Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify that when is multigroup it is required update the Dockerfile as well #3678

Closed
camilamacedo86 opened this issue Aug 7, 2020 · 7 comments
Closed

doc: clarify that when is multigroup it is required update the Dockerfile as well #3678

camilamacedo86 opened this issue Aug 7, 2020 · 7 comments
Assignees
@camilamacedo86
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Milestone
Post 1.0 Docs

Comments

@camilamacedo86
Copy link
Contributor

Steps

  • Create a project and API with controller and resource (QuickStart)
  • Update project file with multigroup: true
  • Run make docker-build

The following issue will be faced
COPY failed: stat /var/lib/docker/tmp/docker-builder031903601/api: no such file or directory
make: *** [Makefile:73: docker-build] Error 1

Solution
Update the Dockerfile.

Replace:
COPY api/ api/

With:

COPY apis/ apis/

Goal of this task

  • Update this info in the Migration Guide
  • Check if we should update it other places as well.
@camilamacedo86 camilamacedo86 added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 7, 2020
@camilamacedo86 camilamacedo86 added this to the Post 1.0 Docs milestone Aug 7, 2020
@joelanford
Copy link
Member

Users would also have to move their existing API in ./api to the appropriate group directory in ./apis, right?

@joelanford
Copy link
Member

This should be documented upstream since this is a purely kubebuilder related issue.

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Aug 7, 2020 •
edited

hi @joelanford,

Users would also have to move their existing API in ./api to the appropriate group directory in ./apis, right?

Yes

This should be documented upstream since this is a purely kubebuilder related issue.

Upstream has a command kubebuilder edit --multigroup=true to do that. So, we cannot address users to its docs. See; https://book.kubebuilder.io/migration/multi-group.html.

Also, wdyt about we have this command as a plugin as well in upstream to use here.

@miguelsorianod
Copy link
Contributor

miguelsorianod commented Oct 22, 2020 •
edited

Hi,

I've reproduced the reported issue here when working on an operator project.

Is there some way I can help with this?

Thank you.

@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Oct 22, 2020 •
edited

Hi @miguelsorianod,

IMO what I think that we really to do is:

@joelanford @estroz wdyt?

@camilamacedo86 camilamacedo86 self-assigned this Oct 30, 2020
@camilamacedo86 camilamacedo86 mentioned this issue Nov 1, 2020
Merged
2 tasks
@camilamacedo86
Copy link
Contributor Author

Done : https://github.com/operator-framework/operator-sdk/pull/4156/files

camilamacedo86 added a commit that referenced this issue Nov 11, 2020
@camilamacedo86
feat and bugfixes: update kb and add edit command to support multigro…
0859bd2 
…ups (#4156)

**Description of the change:**
- Update kubebuilder dependency (See: kubernetes-sigs/kubebuilder@36124ae...9c02d55)
- Add edit command which allows multigroup support
- Align SDK with Kubebuilder and address bug fixes

**Motivation for the change:**
- Solve tech-debt and keep both projects aligned
- Close the issue: #3678 and provide the same facility that has in upstream to change the layout to support multigroup  
- Close the issue: #4157
@camilamacedo86
Copy link
Contributor Author

It is done in the PR #4156

reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this issue Feb 5, 2021
@camilamacedo86
feat and bugfixes: update kb and add edit command to support multigro…
5e6f050 
…ups (operator-framework#4156)

**Description of the change:**
- Update kubebuilder dependency (See: kubernetes-sigs/kubebuilder@36124ae...9c02d55)
- Add edit command which allows multigroup support
- Align SDK with Kubebuilder and address bug fixes

**Motivation for the change:**
- Solve tech-debt and keep both projects aligned
- Close the issue: operator-framework#3678 and provide the same facility that has in upstream to change the layout to support multigroup  
- Close the issue: operator-framework#4157

Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
rearl-scwx pushed a commit to rearl-scwx/operator-sdk that referenced this issue Feb 5, 2021
@camilamacedo86 @rearl-scwx
feat and bugfixes: update kb and add edit command to support multigro…
105dc34 
…ups (operator-framework#4156)

**Description of the change:**
- Update kubebuilder dependency (See: kubernetes-sigs/kubebuilder@36124ae...9c02d55)
- Add edit command which allows multigroup support
- Align SDK with Kubebuilder and address bug fixes

**Motivation for the change:**
- Solve tech-debt and keep both projects aligned
- Close the issue: operator-framework#3678 and provide the same facility that has in upstream to change the layout to support multigroup  
- Close the issue: operator-framework#4157

Signed-off-by: rearl <rearl@secureworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camilamacedo86 camilamacedo86

Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
Post 1.0 Docs
Development

No branches or pull requests
3 participants
@joelanford @camilamacedo86 @miguelsorianod