Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise the name of the tasks by default in the molecule tests #4311

Closed
camilamacedo86 opened this issue Dec 14, 2020 · 2 comments
Closed

Raise the name of the tasks by default in the molecule tests #4311

camilamacedo86 opened this issue Dec 14, 2020 · 2 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. language/ansible Issue is related to an Ansible operator project
Milestone

Comments

@camilamacedo86
Copy link
Contributor

camilamacedo86 commented Dec 14, 2020

Feature Request

Describe the problem you need a feature to resolve.

I'd like to know what task fails in the Molecule tests as it was possible before 1.0+.

Describe the solution you'd like.

Update the default scaffold molecule/default/verify.yml with :

 - name: Re-emit failure
          vars:
            failed_task:
              name: '{{ ansible_failed_task.name }}' // this is the only line that needs to be added 
              result: '{{ ansible_failed_result }}'
          fail:
            msg: '{{ failed_task }}'

However, I think we cannot scaffold it in the init. The ansible_failed_task will only exist after we scaffold a task for molecule ( create api be executed ).

/language ansible

@openshift-ci-robot openshift-ci-robot added the language/ansible Issue is related to an Ansible operator project label Dec 14, 2020
@estroz estroz added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 14, 2020
@estroz estroz added this to the Backlog milestone Dec 14, 2020
@camilamacedo86
Copy link
Contributor Author

camilamacedo86 commented Dec 15, 2020

The PR #4318 has its solution, however, to finish it is required to:

c/c @asmacdo @estroz

@camilamacedo86
Copy link
Contributor Author

I am closing this one after a deeper check on it I realized that the variable is no longer defined for the new molecule tests and that the existent one (ansible_failed_result) will return all data indeed the task name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. language/ansible Issue is related to an Ansible operator project
Projects
None yet
Development

No branches or pull requests

3 participants