Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add new extension to markers in order to allow work with .yml #1907

Merged
merged 1 commit into from
Dec 15, 2020
Merged

✨ add new extension to markers in order to allow work with .yml #1907

merged 1 commit into from
Dec 15, 2020

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Dec 15, 2020 •
edited
Loading

Description

✨ add a new extension to markers in order to allow work with .yml

Motivation

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 15, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2020
@camilamacedo86 camilamacedo86 requested review from estroz and removed request for joelanford December 15, 2020 11:14
@coderanger
Copy link

/lgtm

@k8s-ci-robot
Copy link
Contributor

@coderanger: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Dec 15, 2020
Closed
Closed
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-18-0

@Adirio
Copy link
Contributor

Adirio commented Dec 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit a4ad49a into kubernetes-sigs:master Dec 15, 2020
@camilamacedo86 camilamacedo86 deleted the add-marker-extension branch December 15, 2020 15:20
@camilamacedo86 camilamacedo86 mentioned this pull request Dec 15, 2020
Merged
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adirio Adirio Awaiting requested review from Adirio

@estroz estroz Awaiting requested review from estroz

Assignees

@Adirio Adirio

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@camilamacedo86 @k8s-ci-robot @coderanger @Adirio